darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 17:01:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

A small change to make the code just a little bit clearer.

Browse Source
This commit is contained in:
Rebecca Law
2019-10-17 15:17:43 +01:00
parent 6ee7ac6cac
commit ad14f96b8d
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/celery/letters_pdf_tasks.py
View File

@@ -209,9 +209,8 @@ def process_virus_scan_passed(self, filename):
old_pdf = scan_pdf_object.get()['Body'].read() old_pdf = scan_pdf_object.get()['Body'].read()
sanitise_response, result = _sanitise_precompiled_pdf(self, notification, old_pdf) sanitise_response, result = _sanitise_precompiled_pdf(self, notification, old_pdf)
if result == "validation_failed": new_pdf = None
new_pdf = None if result == 'validation_passed':
else:
new_pdf = base64.b64decode(sanitise_response["file"].encode()) new_pdf = base64.b64decode(sanitise_response["file"].encode())
redaction_failed_message = sanitise_response.get("redaction_failed_message") redaction_failed_message = sanitise_response.get("redaction_failed_message")
@@ -228,7 +227,7 @@ def process_virus_scan_passed(self, filename):
# Check your state pension submit letters with good addresses and notify tags, so just use their supplied pdf # Check your state pension submit letters with good addresses and notify tags, so just use their supplied pdf
new_pdf = old_pdf new_pdf = old_pdf
if not new_pdf: if result == 'validation_failed' and not new_pdf:
current_app.logger.info('Invalid precompiled pdf received {} ({})'.format(notification.id, filename)) current_app.logger.info('Invalid precompiled pdf received {} ({})'.format(notification.id, filename))
_move_invalid_letter_and_update_status( _move_invalid_letter_and_update_status(
notification=notification, notification=notification,
@@ -239,9 +238,6 @@ def process_virus_scan_passed(self, filename):
page_count=sanitise_response.get("page_count") page_count=sanitise_response.get("page_count")
) )
return return
else:
current_app.logger.info(
"Validation was successful for precompiled pdf {} ({})".format(notification.id, filename))
current_app.logger.info('notification id {} ({}) sanitised and ready to send'.format(notification.id, filename)) current_app.logger.info('notification id {} ({}) sanitised and ready to send'.format(notification.id, filename))