From 51f43563d33e5500491b6f51c5dbce850cf9e5f6 Mon Sep 17 00:00:00 2001 From: Rebecca Law Date: Tue, 17 Mar 2020 08:48:02 +0000 Subject: [PATCH] Fix serialisation error when creating the `create_letters_pdf` in `resend_created_notifications_older_than` --- app/celery/scheduled_tasks.py | 2 +- tests/app/celery/test_scheduled_tasks.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/celery/scheduled_tasks.py b/app/celery/scheduled_tasks.py index a32551e08..e0c419534 100644 --- a/app/celery/scheduled_tasks.py +++ b/app/celery/scheduled_tasks.py @@ -205,7 +205,7 @@ def replay_created_notifications(): current_app.logger.info(msg) for letter in letters: - create_letters_pdf.apply_async([letter.id], queue=QueueNames.LETTERS) + create_letters_pdf.apply_async([str(letter.id)], queue=QueueNames.LETTERS) @notify_celery.task(name='check-precompiled-letter-state') diff --git a/tests/app/celery/test_scheduled_tasks.py b/tests/app/celery/test_scheduled_tasks.py index 81c3ee8ce..bb43251c6 100644 --- a/tests/app/celery/test_scheduled_tasks.py +++ b/tests/app/celery/test_scheduled_tasks.py @@ -329,8 +329,8 @@ def test_replay_created_notifications_create_letters_pdf_tasks_for_letters_not_r replay_created_notifications() - calls = [call([notification_1.id], queue=QueueNames.LETTERS), - call([notification_2.id], queue=QueueNames.LETTERS), + calls = [call([str(notification_1.id)], queue=QueueNames.LETTERS), + call([str(notification_2.id)], queue=QueueNames.LETTERS), ] mock_task.assert_has_calls(calls, any_order=True)