fix code for vulture

This commit is contained in:
Kenneth Kehl
2023-08-08 11:48:19 -07:00
parent 3cf5ea8802
commit abd1898150
2 changed files with 7 additions and 6 deletions

View File

@@ -357,17 +357,17 @@ def setup_sqlalchemy_events(app):
# need this or db.engine isn't accessible # need this or db.engine isn't accessible
with app.app_context(): with app.app_context():
@event.listens_for(db.engine, 'connect') @event.listens_for(db.engine, 'connect')
def connect(dbapi_connection, connection_record): def connect():
# connection first opened with db # connection first opened with db
TOTAL_DB_CONNECTIONS.inc() TOTAL_DB_CONNECTIONS.inc()
@event.listens_for(db.engine, 'close') @event.listens_for(db.engine, 'close')
def close(dbapi_connection, connection_record): def close():
# connection closed (probably only happens with overflow connections) # connection closed (probably only happens with overflow connections)
TOTAL_DB_CONNECTIONS.dec() TOTAL_DB_CONNECTIONS.dec()
@event.listens_for(db.engine, 'checkout') @event.listens_for(db.engine, 'checkout')
def checkout(dbapi_connection, connection_record, connection_proxy): def checkout(connection_record):
try: try:
# connection given to a web worker # connection given to a web worker
TOTAL_CHECKED_OUT_DB_CONNECTIONS.inc() TOTAL_CHECKED_OUT_DB_CONNECTIONS.inc()
@@ -405,7 +405,7 @@ def setup_sqlalchemy_events(app):
current_app.logger.exception("Exception caught for checkout event.") current_app.logger.exception("Exception caught for checkout event.")
@event.listens_for(db.engine, 'checkin') @event.listens_for(db.engine, 'checkin')
def checkin(dbapi_connection, connection_record): def checkin(connection_record):
try: try:
# connection returned by a web worker # connection returned by a web worker
TOTAL_CHECKED_OUT_DB_CONNECTIONS.dec() TOTAL_CHECKED_OUT_DB_CONNECTIONS.dec()

View File

@@ -572,8 +572,9 @@ def populate_annual_billing_with_defaults(year, missing_services_only):
print(f'update service {service.id} with default') print(f'update service {service.id} with default')
set_default_free_allowance_for_service(service, year) set_default_free_allowance_for_service(service, year)
# We use noqa to protect this method from the vulture dead code check. Otherwise, the params ctx and param
def validate_mobile(ctx, param, value): # will trigger vulture and cause a build failure.
def validate_mobile(ctx, param, value): # noqa
if (len(''.join(i for i in value if i.isdigit())) != 10): if (len(''.join(i for i in value if i.isdigit())) != 10):
raise click.BadParameter("mobile number must have 10 digits") raise click.BadParameter("mobile number must have 10 digits")
else: else: