darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-19 14:08:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove alert for email / sms in created

Browse Source 
In response to [1].

[1]: https://github.com/alphagov/notifications-api/pull/3383#discussion_r759379988

It turns out the code that inspired this new alert - in the old
"timeout-sending-notifications" task - was actually redundant as
we already have a task to "replay" notifications still in "created",
which is much better than just alerting about them.

It's possible the replayed notifications will also fail, but in
both cases we should see some kind of error due to this, so I don't
think we're losing anything by not having an alert.
This commit is contained in:
Ben Thorner
2021-12-06 14:07:52 +00:00
parent 9bd2a9b427
commit ab4cb029df
5 changed files with 0 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/celery/scheduled_tasks.py
View File

@@ -30,7 +30,6 @@ from app.dao.jobs_dao import (
find_missing_row_for_job,
)
from app.dao.notifications_dao import (
dao_check_notifications_still_in_created,
dao_old_letters_with_created_status,
dao_precompiled_letters_still_pending_virus_check,
is_delivery_slow_for_providers,
@@ -119,19 +118,6 @@ def switch_current_sms_provider_on_slow_delivery():
dao_reduce_sms_provider_priority(provider_name, time_threshold=timedelta(minutes=10))
@notify_celery.task(name='raise-alert-if-email-sms-still-in-created')
def raise_alert_if_email_sms_still_in_created():
alert_above_age = current_app.config.get('CREATED_NOTIFICATIONS_ALERT_AGE')
still_in_created = dao_check_notifications_still_in_created(alert_above_age)
message = f"{still_in_created} notifications are still in 'created'."
if still_in_created == 0:
current_app.logger.info(message)
return
current_app.logger.error(message)
@notify_celery.task(name='tend-providers-back-to-middle')
def tend_providers_back_to_middle():
dao_adjust_provider_priority_back_to_resting_points()

6
app/config.py
View File

@@ -310,11 +310,6 @@ class Config(object):
'schedule': crontab(hour=15, minute=30),
'options': {'queue': QueueNames.PERIODIC}
},
'raise-alert-if-email-sms-still-in-created': {
'task': 'raise-alert-if-email-sms-still-in-created',
'schedule': crontab(minute=30),
'options': {'queue': QueueNames.PERIODIC},
},
# The collate-letter-pdf does assume it is called in an hour that BST does not make a
# difference to the truncate date which translates to the filename to process
'collate-letter-pdfs-to-be-sent': {
@@ -360,7 +355,6 @@ class Config(object):
STATSD_ENABLED = bool(STATSD_HOST)
SENDING_NOTIFICATIONS_TIMEOUT_PERIOD = 259200 # 3 days
CREATED_NOTIFICATIONS_ALERT_AGE = 3600 # 1 hour
SIMULATED_EMAIL_ADDRESSES = (
'simulate-delivered@notifications.service.gov.uk',

10
app/dao/notifications_dao.py
View File

@@ -487,16 +487,6 @@ def dao_delete_notifications_by_id(notification_id):
).delete(synchronize_session='fetch')
def dao_check_notifications_still_in_created(minimum_age_in_seconds):
min_created_at = datetime.utcnow() - timedelta(seconds=minimum_age_in_seconds)
return Notification.query.filter(
Notification.created_at < min_created_at,
Notification.status == NOTIFICATION_CREATED,
Notification.notification_type.in_([SMS_TYPE, EMAIL_TYPE])
).count()
def dao_timeout_notifications(timeout_period_in_seconds):
"""
Timeout SMS and email notifications by the following rules: