darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-10 07:12:20 -05:00
Code Issues Packages Projects Releases Wiki Activity

Added a couple of notes about engaging in conversation

Browse Source 
h/t to @stvnrlly for the suggestion!

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
This commit is contained in:
Carlo Costino
2024-02-12 13:27:29 -05:00
parent d9e6ebdbe3
commit aabb822824
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
docs/all.md
View File

@@ -809,6 +809,11 @@ mind:
it looks big and red when it shows up, but this is completely fine and not to
be taken as a personal mark against the author(s) of the pull request!
Additionally, if you find yourself making a lot of comments and/or end up having
several concerns about the overall approach, it will likely be helpful to
schedule time to speak with the author(s) directly and talk through everything.
This can save folks a lot of misunderstanding and back-and-forth!
### For the reviewee
When receiving a code review, please remember that someone took the time to look
@@ -839,6 +844,11 @@ When going over a review, it may be helpful to keep these perspectives in mind:
the necessary adjustments and let the reviewer(s) know when the work is ready
for review again.
Additionally, if you find yourself responding to a lot of things and questioning
the feedback received throughout much of the code review, it will likely be
helpful to schedule time to speak with the reviewer(s) directly and talk through
everything. This can save folks a lot of misunderstanding and back-and-forth!
Run Book
========