darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-22 00:11:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

Test for HTML response in the schema

Browse Source 
Because we test for the other properties in the schema.

Also sets `additionalProperties` to `False` so we’re forced to update
the schemas if we make similar changes in the future. This means
removing `created_by` from the test data because it’s not returned by
the real response.
This commit is contained in:
Chris Hill-Scott
2019-02-08 11:33:36 +00:00
parent f185dbecbe
commit aab36157a5
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/v2/template/template_schemas.py
View File

@@ -66,9 +66,11 @@ post_template_preview_response = {
"version": {"type": "integer"}, "version": {"type": "integer"},
"body": {"type": "string"}, "body": {"type": "string"},
"subject": {"type": ["string", "null"]}, "subject": {"type": ["string", "null"]},
"postage": {"type": "string"} "postage": {"type": "string"},
"html": {"type": ["string", "null"]},
}, },
"required": ["id", "type", "version", "body"] "required": ["id", "type", "version", "body"],
"additionalProperties": False,
} }

7
tests/app/v2/template/test_template_schemas.py
View File

@@ -71,17 +71,16 @@ valid_json_post_response = {
'id': str(uuid.uuid4()), 'id': str(uuid.uuid4()),
'type': 'email', 'type': 'email',
'version': 1, 'version': 1,
'created_by': 'someone@test.com', 'body': 'some body',
'body': 'some body'
} }
valid_json_post_response_with_optionals = { valid_json_post_response_with_optionals = {
'id': str(uuid.uuid4()), 'id': str(uuid.uuid4()),
'type': 'email', 'type': 'email',
'version': 1, 'version': 1,
'created_by': 'someone@test.com',
'body': "some body", 'body': "some body",
'subject': 'some subject' 'subject': 'some subject',
'html': '<p>some body</p>',
} }