darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-21 07:51:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #655 from alphagov/mmg-update-status

Browse Source 
Update MMG status code 2 to be a permanent failure.
This commit is contained in:
Rebecca Law
2016-09-02 09:44:24 +01:00
committed by GitHub
parent b294568a91 3d41fa9634
commit aa8ee3a8da
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/clients/sms/mmg.py
View File

@@ -6,10 +6,10 @@ from app.clients.sms import (SmsClient, SmsClientException)
mmg_response_map = { mmg_response_map = {
'2': { '2': {
"message": ' Temporary failure', "message": ' Permanent failure',
"notification_statistics_status": STATISTICS_FAILURE, "notification_statistics_status": STATISTICS_FAILURE,
"success": False, "success": False,
"notification_status": 'temporary-failure' "notification_status": 'permanent-failure'
}, },
'3': { '3': {
"message": 'Delivered', "message": 'Delivered',

4
tests/app/notifications/rest/test_callbacks.py
View File

@@ -297,7 +297,7 @@ def test_process_mmg_response_status_5_updates_notification_with_permanently_fai
assert get_notification_by_id(sample_notification.id).status == 'permanent-failure' assert get_notification_by_id(sample_notification.id).status == 'permanent-failure'
def test_process_mmg_response_status_2_updates_notification_with_temporary_failed(notify_api, def test_process_mmg_response_status_2_updates_notification_with_permanently_failed(notify_api,
sample_notification): sample_notification):
with notify_api.test_client() as client: with notify_api.test_client() as client:
data = json.dumps({"reference": "mmg_reference", data = json.dumps({"reference": "mmg_reference",
@@ -312,7 +312,7 @@ def test_process_mmg_response_status_2_updates_notification_with_temporary_faile
json_data = json.loads(response.data) json_data = json.loads(response.data)
assert json_data['result'] == 'success' assert json_data['result'] == 'success'
assert json_data['message'] == 'MMG callback succeeded. reference {} updated'.format(sample_notification.id) assert json_data['message'] == 'MMG callback succeeded. reference {} updated'.format(sample_notification.id)
assert get_notification_by_id(sample_notification.id).status == 'temporary-failure' assert get_notification_by_id(sample_notification.id).status == 'permanent-failure'
def test_process_mmg_response_status_4_updates_notification_with_temporary_failed(notify_api, def test_process_mmg_response_status_4_updates_notification_with_temporary_failed(notify_api,