darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-12 00:02:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Drop making crown not nullable on downgrade as it would fail anyway

Browse Source
This commit is contained in:
Pea Tyczynska
2019-07-18 15:16:37 +01:00
parent 610bf5d149
commit aa88252cf7
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
migrations/versions/0299_org_types_table.py
View File

@@ -43,5 +43,3 @@ def upgrade():
def downgrade(): def downgrade():
op.execute('DROP TABLE organisation_types') op.execute('DROP TABLE organisation_types')
op.alter_column('services', 'crown', nullable=False)
op.alter_column('services_history', 'crown', nullable=False)

2
tests/app/organisation/test_rest.py
View File

@@ -204,7 +204,7 @@ def test_post_create_organisation_existing_name_raises_400(admin_request, sample
'name': 'Service name', 'name': 'Service name',
'crown': False, 'crown': False,
'organisation_type': 'foo', 'organisation_type': 'foo',
}, 'organisation_type foo is not one of [central, local, nhs_central, nhs_local, emergency_service, school_or_college, other]'), # noqa }, 'organisation_type foo is not one of [central, local, nhs_central, nhs, nhs_local, emergency_service, school_or_college, other]'), # noqa
)) ))
def test_post_create_organisation_with_missing_data_gives_validation_error( def test_post_create_organisation_with_missing_data_gives_validation_error(
admin_request, admin_request,