darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove check on permission to upload letters

Browse Source 
Soon enough every service will have this permission, and they won’t be
able to switch it off. So we should clean up our codebase and make it
so there’s no dependancy on a row existing in the permissions table.

This is the first step of that process for the API. Before we can remove
it, we have to stop checking from it. Next step will be to stop
inserting the permission, then finally remove it from the database.
This commit is contained in:
Chris Hill-Scott
2020-03-02 14:07:39 +00:00
parent 5c0e65a913
commit aa69139fd1
2 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/app/service/test_send_pdf_letter_notification.py
View File

@@ -13,7 +13,6 @@ from tests.app.db import create_service
@pytest.mark.parametrize('permissions', [
[EMAIL_TYPE],
[LETTER_TYPE],
[UPLOAD_LETTERS],
])
def test_send_pdf_letter_notification_raises_error_if_service_does_not_have_permission(