darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-04 21:50:54 -04:00
Code Issues Packages Projects Releases Wiki Activity

Revert "don't expire email sign in codes on use"

Browse Source
This commit is contained in:
Leo Hemsted
2020-05-05 11:57:15 +01:00
committed by GitHub
parent f67625a9fa
commit a9328f7c33
3 changed files with 21 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/user/rest.py
View File

@@ -190,8 +190,7 @@ def verify_user_code(user_id):
# only relevant from sms
increment_failed_login_count(user_to_verify)
raise InvalidRequest("Code not found", status_code=404)
# TODO: Fix email flow so that clicking link doesn't expire emails
if datetime.utcnow() > code.expiry_datetime or (code.code_used and data['code_type'] != 'email'):
if datetime.utcnow() > code.expiry_datetime or code.code_used:
# sms and email
increment_failed_login_count(user_to_verify)
raise InvalidRequest("Code has expired", status_code=400)