Populate inbound sms history when deleting inbound sms

tests/app/dao/test_inbound_sms_dao.py

@@ -9,8 +9,15 @@ from app.dao.inbound_sms_dao import (
     delete_inbound_sms_older_than_retention,
     dao_get_inbound_sms_by_id,
     dao_get_paginated_inbound_sms_for_service_for_public_api,
-    dao_get_paginated_most_recent_inbound_sms_by_user_number_for_service
+    dao_get_paginated_most_recent_inbound_sms_by_user_number_for_service,
+    db,
+    insert_update_inbound_sms_history
 )
+
+from app.models import InboundSmsHistory
+
+from app.utils import midnight_n_days_ago
+
 from tests.conftest import set_config
 from tests.app.db import create_inbound_sms, create_service, create_service_data_retention
 
@@ -90,7 +97,7 @@ def test_count_inbound_sms_for_service_filters_messages_older_than_n_days(sample
 
 
 @freeze_time("2017-06-08 12:00:00")
-def test_should_delete_inbound_sms_according_to_data_retention(notify_db_session):
+def test_should_delete_inbound_sms_according_to_data_retention(notify_db_session, mocker):
     no_retention_service = create_service(service_name='no retention')
     short_retention_service = create_service(service_name='three days')
     long_retention_service = create_service(service_name='thirty days')
@@ -99,7 +106,6 @@ def test_should_delete_inbound_sms_according_to_data_retention(notify_db_session
 
     create_service_data_retention(long_retention_service, notification_type='sms', days_of_retention=30)
     create_service_data_retention(short_retention_service, notification_type='sms', days_of_retention=3)
-    # email retention doesn't affect anything
     create_service_data_retention(short_retention_service, notification_type='email', days_of_retention=4)
 
     dates = [
@@ -115,6 +121,9 @@ def test_should_delete_inbound_sms_according_to_data_retention(notify_db_session
 
     deleted_count = delete_inbound_sms_older_than_retention()
 
+    history = InboundSmsHistory.query.all()
+    assert len(history) == 7
+
     # four deleted for the 3-day service, two for the default seven days one, one for the 30 day
     assert deleted_count == 7
     assert {
@@ -272,3 +281,65 @@ def test_most_recent_inbound_sms_only_returns_values_within_7_days(sample_servic
 
     assert len(res.items) == 1
     assert res.items[0].content == 'new'
+
+
+def test_insert_update_inbound_sms_history_limits_by_query_by_date(sample_service):
+    # becoming history
+    inbound_1 = create_inbound_sms(
+        sample_service, user_number='1', content='old', created_at=datetime(2017, 4, 2, 22, 59, 59)
+    )
+    # not becoming history yet
+    create_inbound_sms(sample_service, user_number='2', content='new', created_at=datetime(2017, 4, 2, 23, 0, 0))
+
+    with freeze_time('Monday 10th April 2017 12:00:00'):
+        insert_update_inbound_sms_history(
+            date_to_delete_from=midnight_n_days_ago(7),
+            service_id=sample_service.id)
+    history = InboundSmsHistory.query.all()
+    assert len(history) == 1
+
+    assert history[0].id == inbound_1.id
+
+
+def test_insert_update_inbound_sms_history_above_query_limit(sample_service, mocker):
+    # becoming history
+    create_inbound_sms(
+        sample_service, user_number='1', content='old', created_at=datetime(2017, 4, 2, 22, 59, 59)
+    )
+    create_inbound_sms(
+        sample_service, user_number='1', content='old', created_at=datetime(2017, 4, 2, 20, 59, 59)
+    )
+    # not becoming history yet
+    create_inbound_sms(sample_service, user_number='2', content='new', created_at=datetime(2017, 4, 2, 23, 0, 0))
+
+    db_connection_spy = mocker.spy(db.session, 'connection')
+    db_commit_spy = mocker.spy(db.session, 'commit')
+
+    with freeze_time('Monday 10th April 2017 12:00:00'):
+        insert_update_inbound_sms_history(
+            date_to_delete_from=midnight_n_days_ago(7),
+            service_id=sample_service.id,
+            query_limit=1
+        )
+    history = InboundSmsHistory.query.all()
+    assert len(history) == 2
+
+    assert db_connection_spy.call_count == 2
+    assert db_commit_spy.call_count == 2
+
+
+def test_insert_update_inbound_sms_history_only_updates_given_service(sample_service):
+    inbound_1 = create_inbound_sms(
+        sample_service, user_number='1', content='old', created_at=datetime(2017, 4, 2, 22, 59, 59)
+    )
+    other_service = create_service(service_name='another service')
+    create_inbound_sms(other_service, user_number='2', content='new', created_at=datetime(2017, 4, 2, 22, 0, 0))
+
+    with freeze_time('Monday 10th April 2017 12:00:00'):
+        insert_update_inbound_sms_history(
+            date_to_delete_from=midnight_n_days_ago(7),
+            service_id=sample_service.id)
+    history = InboundSmsHistory.query.all()
+    assert len(history) == 1
+
+    assert history[0].id == inbound_1.id