darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-12 08:12:27 -05:00
Code Issues Packages Projects Releases Wiki Activity

new adr process

Browse Source
This commit is contained in:
Steven Reilly
2023-09-11 12:45:24 -04:00
committed by GitHub
parent 33fadb8441
commit a5cd28e24d
1 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
docs/adrs/README.md
View File

@@ -38,9 +38,8 @@ whether or not to move forward, with or without any changes.
## How are ADRs created, reviewed, and maintained? ## How are ADRs created, reviewed, and maintained?
First, we have an ADR template that folks can use to work off of. The template First, we have an ADR issue template that folks can use to start. Select the
exists as both a GitHub issue template and a standalone Markdown file that can "Create a new ADR" option when creating a new issue.
be copied as needed if folks prefer to work locally first.
By following the template, we ensure that our ADRs are consistent in language By following the template, we ensure that our ADRs are consistent in language
and structure. This allows us to easily review the documentions and discuss and structure. This allows us to easily review the documentions and discuss
@@ -82,14 +81,22 @@ be links or the link will go to a :lock: *private document* instead.
To create a new ADR in this repository, you can do one of two things: To create a new ADR in this repository, you can do one of two things:
- Open a new GitHub issue and select the Architecture Decision Record issue type - Open a new GitHub issue and select the "Create a new ADR" option
- Clone the repo locally, create a new branch for yourself, and make a copy of - Clone the repo locally, create a new branch for yourself, and make a copy of
the Markdown template the Markdown template
In either scenario, check to see what the latest ADR filename is, because they Creating an ADR manually should be used primarily when memorializing a decision
always start with a number (e.g., `0001`). Name your ADR with a number one that the team has already made. Anything requiring discussion should be created
after the last ADR written; if the latest ADR starts with `0021-`, your ADR as an issue.
should start with `0022-`.
We are using [some automation]([url](https://github.com/18F/adr-automation/))
to turn proposed-ADR issues into accepted-ADR documents. When an ADR is accepted,
apply the `ADR: accepted` label and close the issue. The action will open a pull
request with the document, which can then be merged.
When working locally, be sure to number your ADR based on the last ADR written;
if the latest ADR starts with `0021-`, for example, your ADR should start with
`0022-`.
At this point, it is a matter of filling in the details outlined in the template At this point, it is a matter of filling in the details outlined in the template
that are relevant to the ADR. that are relevant to the ADR.
@@ -100,7 +107,8 @@ that are relevant to the ADR.
Once an ADR is created, it's time for review and discussion! This could happen Once an ADR is created, it's time for review and discussion! This could happen
a few ways: a few ways:
- Asynchronously via comments on the pull request itself - Asynchronously via comments on the issue itself
- Synchronously-ish on Slack
- Synchronously with a scheduled meeting(s) and a facilitator - Synchronously with a scheduled meeting(s) and a facilitator
- A combination of these, depending on the nature of the ADR and needs of the - A combination of these, depending on the nature of the ADR and needs of the
team team