Reword migration script

This commit is contained in:
Ken Tsang
2017-05-26 14:56:22 +01:00
parent 640ab665d0
commit a5ab427577

View File

@@ -1,14 +1,14 @@
"""empty message
Revision ID: 0086_migrate_existing_svc_perms
Revises: 0085_update_incoming_to_inbound
Revision ID: 0088_migrate_existing_svc_perms
Revises: 0087_scheduled_notifications
Create Date: 2017-05-23 18:13:03.532095
"""
# revision identifiers, used by Alembic.
revision = '0086_migrate_existing_svc_perms'
down_revision = '0085_update_incoming_to_inbound'
revision = '0088_migrate_existing_svc_perms'
down_revision = '0087_scheduled_notifications'
from alembic import op
import sqlalchemy as sa
@@ -20,7 +20,7 @@ def upgrade():
"id NOT IN (SELECT service_id FROM service_permissions "\
"WHERE service_id=id AND permission='{0}')".format(permission)
def get_values_from_flag(permission, flag):
def get_values_if_flag(permission, flag):
return "SELECT id, '{0}' FROM services WHERE "\
"{1} AND id NOT IN (SELECT service_id FROM service_permissions "\
"WHERE service_id=id AND permission='{0}')".format(permission, flag)
@@ -28,9 +28,9 @@ def upgrade():
op.execute("INSERT INTO service_permissions (service_id, permission) {}".format(get_values('sms')))
op.execute("INSERT INTO service_permissions (service_id, permission) {}".format(get_values('email')))
op.execute("INSERT INTO service_permissions (service_id, permission) {}".format(
get_values_from_flag('letter', 'can_send_letters')))
get_values_if_flag('letter', 'can_send_letters')))
op.execute("INSERT INTO service_permissions (service_id, permission) {}".format(
get_values_from_flag('international_sms', 'can_send_international_sms')))
get_values_if_flag('international_sms', 'can_send_international_sms')))
def downgrade():