darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-11 15:52:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixed more unit tests

Browse Source
This commit is contained in:
alexjanousekGSA
2025-05-30 16:42:52 -04:00
parent aa445f5f40
commit a431ccfb73
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/schemas.py
View File

@@ -768,7 +768,9 @@ class UnarchivedTemplateSchema(BaseSchema):
# should not be used on its own for dumping - only for loading
create_user_schema = UserSchema()
user_update_schema_load_json = UserUpdateAttributeSchema(load_json=True, partial=True)
user_update_schema_load_json = UserUpdateAttributeSchema(
load_json=True, partial=True, transient=True
)
user_update_password_schema_load_json = UserUpdatePasswordSchema(
only=("_password",), load_json=True, partial=True
)
@@ -785,6 +787,7 @@ invited_user_schema = InvitedUserSchema()
email_data_request_schema = EmailDataSchema()
partial_email_data_request_schema = EmailDataSchema(partial_email=True)
notifications_filter_schema = NotificationsFilterSchema()
public_notification_response_schema = NotificationWithTemplateSchema()
service_history_schema = ServiceHistorySchema()
api_key_history_schema = ApiKeyHistorySchema()
template_history_schema = TemplateHistorySchema()

12
tests/app/test_schemas.py
View File

@@ -67,7 +67,9 @@ def test_notification_schema_has_correct_status(sample_notification, schema_name
("mobile_number", "+14254147755"),
],
)
def test_user_update_schema_accepts_valid_attribute_pairs(user_attribute, user_value):
def test_user_update_schema_accepts_valid_attribute_pairs(
notify_api, user_attribute, user_value
):
update_dict = {user_attribute: user_value}
from app.schemas import user_update_schema_load_json
@@ -84,7 +86,9 @@ def test_user_update_schema_accepts_valid_attribute_pairs(user_attribute, user_v
("mobile_number", "+44077009"),
],
)
def test_user_update_schema_rejects_invalid_attribute_pairs(user_attribute, user_value):
def test_user_update_schema_rejects_invalid_attribute_pairs(
notify_api, user_attribute, user_value
):
from app.schemas import user_update_schema_load_json
update_dict = {user_attribute: user_value}
@@ -109,7 +113,9 @@ def test_user_update_schema_rejects_invalid_attribute_pairs(user_attribute, user
"platform_admin",
],
)
def test_user_update_schema_rejects_disallowed_attribute_keys(user_attribute):
def test_user_update_schema_rejects_disallowed_attribute_keys(
notify_api, user_attribute
):
update_dict = {user_attribute: "not important"}
from app.schemas import user_update_schema_load_json