darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 09:51:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix notifications

Browse Source
This commit is contained in:
Kenneth Kehl
2024-11-19 13:03:42 -08:00
parent fd7b3b9187
commit a3658ce152
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -952,11 +952,8 @@ def test_should_return_notifications_including_one_offs_by_default(
assert len(include_one_offs_by_default) == 2
# TODO this test fails with the sqlalchemy 2.0 upgrade, but
# it seems like it was wrong to begin with. Clearly 2 notifications
# are created, so it seems like the count should be 2, and there is
# no reason to null out or override the pagination object just because
# a flag is being passed.
# TODO this test seems a little bogus. Why are we messing with the pagination object
# based on a flag?
def test_should_not_count_pages_when_given_a_flag(sample_user, sample_template):
create_notification(sample_template)
notification = create_notification(sample_template)
@@ -965,6 +962,8 @@ def test_should_not_count_pages_when_given_a_flag(sample_user, sample_template):
sample_template.service_id, count_pages=False, page_size=1
)
assert len(pagination.items) == 1
# In the original test this was set to None, but pagination has completely changed
# in sqlalchemy 2 so updating the test to what it delivers.
assert pagination.total == 2
assert pagination.items[0].id == notification.id