darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 00:41:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3132 from alphagov/created-letters-runbook

Browse Source 
Improvements to our letter checking tasks
This commit is contained in:
David McDonald
2021-02-12 16:30:42 +00:00
committed by GitHub
parent 9b940637a5 5526c89c34
commit a1e539e785
3 changed files with 25 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/celery/scheduled_tasks.py
View File

@@ -192,9 +192,9 @@ def replay_created_notifications():
get_pdf_for_templated_letter.apply_async([str(letter.id)], queue=QueueNames.CREATE_LETTERS_PDF)
@notify_celery.task(name='check-precompiled-letter-state')
@notify_celery.task(name='check-if-letters-still-pending-virus-check')
@statsd(namespace="tasks")
def check_precompiled_letter_state():
def check_if_letters_still_pending_virus_check():
letters = dao_precompiled_letters_still_pending_virus_check()
if len(letters) > 0:
@@ -214,16 +214,18 @@ def check_precompiled_letter_state():
)
@notify_celery.task(name='check-templated-letter-state')
@notify_celery.task(name='check-if-letters-still-in-created')
@statsd(namespace="tasks")
def check_templated_letter_state():
def check_if_letters_still_in_created():
letters = dao_old_letters_with_created_status()
if len(letters) > 0:
letter_ids = [str(letter.id) for letter in letters]
msg = "{} letters were created before 17.30 yesterday and still have 'created' status. " \
"Notifications: {}".format(len(letters), letter_ids)
"Follow runbook to resolve: " \
"https://github.com/alphagov/notifications-manuals/wiki/Support-Runbook#deal-with-Letters-still-in-created. " \
"Notifications: {}".format(len(letters), letter_ids)
current_app.logger.warning(msg)

8
app/config.py
View File

@@ -286,13 +286,13 @@ class Config(object):
# since we mark jobs as archived
'options': {'queue': QueueNames.PERIODIC},
},
'check-templated-letter-state': {
'task': 'check-templated-letter-state',
'check-if-letters-still-in-created': {
'task': 'check-if-letters-still-in-created',
'schedule': crontab(day_of_week='mon-fri', hour=9, minute=0),
'options': {'queue': QueueNames.PERIODIC}
},
'check-precompiled-letter-state': {
'task': 'check-precompiled-letter-state',
'check-if-letters-still-pending-virus-check': {
'task': 'check-if-letters-still-pending-virus-check',
'schedule': crontab(day_of_week='mon-fri', hour='9,15', minute=0),
'options': {'queue': QueueNames.PERIODIC}
},