darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-20 15:31:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

code review feedback

Browse Source
This commit is contained in:
Kenneth Kehl
2024-01-19 09:02:44 -08:00
parent 510e67e20b
commit a100f60369
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/aws/s3.py
View File

@@ -158,9 +158,14 @@ def get_phone_number_from_s3(service_id, job_id, job_row_number):
return phone_to_return return phone_to_return
else: else:
current_app.logger.warning( current_app.logger.warning(
"Was unable to retrieve phone number from lookup dictionary for job {job_id}" f"Was unable to retrieve phone number from lookup dictionary for job {job_id}"
) )
return "Unknown Phone" return "Unknown Phone"
else:
current_app.logger.error(
f"Was unable to construct lookup dictionary for job {job_id}"
)
return "Unknown Phone"
def get_job_metadata_from_s3(service_id, job_id): def get_job_metadata_from_s3(service_id, job_id):