darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 18:01:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

don't retry task if InvalidEmailError

Browse Source 
just record it as a technical error - retrying wont fix a bad email
This commit is contained in:
Leo Hemsted
2016-10-13 15:27:47 +01:00
parent c0c62e02b7
commit a095aa41f3
3 changed files with 35 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
app/clients/email/aws_ses.py
View File

@@ -1,6 +1,9 @@
import boto3
import botocore
from flask import current_app
from monotonic import monotonic
from notifications_utils.recipients import InvalidEmailError
from app.clients import STATISTICS_DELIVERED, STATISTICS_FAILURE
from app.clients.email import (EmailClientException, EmailClient)
@@ -92,13 +95,18 @@ class AwsSesClient(EmailClient):
},
ReplyToAddresses=reply_to_addresses
)
except botocore.exceptions.ClientError as e:
if e.response['Error']['Code'] == 'InvalidParameterValue':
raise InvalidEmailError('email: "{}" message: "{}"'.format(
to_addresses[0],
e.response['Error']['Message']
))
except Exception as e:
# TODO logging exceptions
self.statsd_client.incr("clients.ses.error")
raise AwsSesClientException(str(e))
elapsed_time = monotonic() - start_time
current_app.logger.info("AWS SES request finished in {}".format(elapsed_time))
self.statsd_client.timing("clients.ses.request-time", elapsed_time)
self.statsd_client.incr("clients.ses.success")
return response['MessageId']
else:
elapsed_time = monotonic() - start_time
current_app.logger.info("AWS SES request finished in {}".format(elapsed_time))
self.statsd_client.timing("clients.ses.request-time", elapsed_time)
self.statsd_client.incr("clients.ses.success")
return response['MessageId']