darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 00:41:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

Serialise notifications for csv separately:

Browse Source 
* Introduces separate method on Notification to serialise the notification
* ready for csv output
* Fixes issue where job_row_number = 0 not being accounted for correctly
This commit is contained in:
Imdad Ahad
2017-04-20 11:52:00 +01:00
parent 67002cd608
commit 9fbd43c072
3 changed files with 149 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/app/conftest.py
View File

@@ -405,14 +405,13 @@ def sample_notification_with_job(
):
if job is None:
job = sample_job(notify_db, notify_db_session, service=service, template=template)
return sample_notification(
notify_db,
notify_db_session,
service,
template,
job=job,
job_row_number=job_row_number if job_row_number else None,
job_row_number=job_row_number if job_row_number is not None else None,
to_field=to_field,
status=status,
reference=reference,
@@ -482,7 +481,7 @@ def sample_notification(
'updated_at': created_at if status in NOTIFICATION_STATUS_TYPES_COMPLETED else None,
'client_reference': client_reference
}
if job_row_number:
if job_row_number is not None:
data['job_row_number'] = job_row_number
notification = Notification(**data)
dao_create_notification(notification)