diff --git a/tests/app/dao/test_provider_details_dao.py b/tests/app/dao/test_provider_details_dao.py index 471632ebf..bcef14a88 100644 --- a/tests/app/dao/test_provider_details_dao.py +++ b/tests/app/dao/test_provider_details_dao.py @@ -6,17 +6,17 @@ from app.dao.provider_details_dao import ( ) -def test_can_get_all_providers(notify_db, notify_db_session): +def test_can_get_all_providers(restore_provider_details): assert len(get_provider_details()) == 4 -def test_can_get_sms_providers(notify_db, notify_db_session): - assert len(get_provider_details_by_notification_type('sms')) == 3 - types = [provider.notification_type for provider in get_provider_details_by_notification_type('sms')] - assert all('sms' == notification_type for notification_type in types) +def test_can_get_sms_providers(restore_provider_details): + sms_providers = get_provider_details_by_notification_type('sms') + assert len(sms_providers) == 3 + assert all('sms' == prov.notification_type for prov in sms_providers) -def test_can_get_sms_providers_in_order(notify_db, notify_db_session): +def test_can_get_sms_providers_in_order(restore_provider_details): providers = get_provider_details_by_notification_type('sms') assert providers[0].identifier == "mmg" @@ -24,35 +24,21 @@ def test_can_get_sms_providers_in_order(notify_db, notify_db_session): assert providers[2].identifier == "loadtesting" -def test_can_get_email_providers_in_order(notify_db, notify_db_session): +def test_can_get_email_providers_in_order(restore_provider_details): providers = get_provider_details_by_notification_type('email') assert providers[0].identifier == "ses" -def test_can_get_email_providers(notify_db, notify_db_session): +def test_can_get_email_providers(restore_provider_details): assert len(get_provider_details_by_notification_type('email')) == 1 types = [provider.notification_type for provider in get_provider_details_by_notification_type('email')] assert all('email' == notification_type for notification_type in types) -def test_should_error_if_any_provider_in_database_not_in_code(notify_db, notify_db_session, notify_api): - providers = ProviderDetails.query.all() - - for provider in providers: - if provider.notification_type == 'sms': - assert clients.get_sms_client(provider.identifier) - if provider.notification_type == 'email': - assert clients.get_email_client(provider.identifier) - - -def test_should_not_error_if_any_provider_in_code_not_in_database(notify_db, notify_db_session, notify_api): +def test_should_not_error_if_any_provider_in_code_not_in_database(restore_provider_details): providers = ProviderDetails.query.all() ProviderDetails.query.filter_by(identifier='mmg').delete() - for provider in providers: - if provider.notification_type == 'sms': - assert clients.get_sms_client(provider.identifier) - if provider.notification_type == 'email': - assert clients.get_email_client(provider.identifier) + assert clients.get_sms_client('mmg')