darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 18:31:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2824 from alphagov/stop-searching-to-field

Browse Source 
Stop searching the to field
This commit is contained in:
Chris Hill-Scott
2020-05-05 16:20:17 +01:00
committed by GitHub
parent 7e2381e719 1e20cb6be9
commit 9f6bfb1b4e
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/dao/notifications_dao.py
View File

@@ -622,7 +622,6 @@ def dao_get_notifications_by_recipient_or_reference(service_id, search_term, not
filters = [
Notification.service_id == service_id,
or_(
Notification.to.ilike("%{}%".format(search_term)),
Notification.normalised_to.like("%{}%".format(normalised)),
Notification.client_reference.ilike("%{}%".format(search_term)),
),

9
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -1319,13 +1319,12 @@ def test_dao_get_notifications_by_reference(
assert results[1].id == email.id
assert results[2].id == sms.id
# If notification_type isn’t specified then we can’t normalise the phone number
# to 4477… but this query will still find the 077… variant in the `to` field,
# as well as the email
# If notification_type isn’t specified then we can’t normalise the
# phone number to 4477… so this query will only find the email sent
# to 077@example.com
results = dao_get_notifications_by_recipient_or_reference(service.id, '077')
assert len(results) == 2
assert len(results) == 1
assert results[0].id == email.id
assert results[1].id == sms.id
results = dao_get_notifications_by_recipient_or_reference(service.id, '077@')
assert len(results) == 1