darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 00:41:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor tests to be a bit more readable

Browse Source 
Make arguments more verbose and have pytest params as inputs at the
start and expected things at the end
This commit is contained in:
David McDonald
2020-03-09 13:42:07 +00:00
parent d168dd106e
commit 9eda30f4fd
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/app/template/test_rest.py
View File

@@ -1143,13 +1143,13 @@ def test_preview_letter_template_precompiled_s3_error(
@pytest.mark.parametrize( @pytest.mark.parametrize(
"filetype, post_url, message, requested_page", "requested_page, filetype, message, expected_post_url",
[ [
('png', 'precompiled-preview.png', "", ""), ("", 'png', "", 'precompiled-preview.png'),
('png', 'precompiled/overlay.png?page_number=1', "content-outside-printable-area", "1"), ("1", 'png', "content-outside-printable-area", 'precompiled/overlay.png?page_number=1'),
('png', 'precompiled/overlay.png?page_number=2', "content-outside-printable-area", "2"), ("2", 'png', "content-outside-printable-area", 'precompiled/overlay.png?page_number=2'),
('png', 'precompiled/overlay.png?page_number=3', "content-outside-printable-area", "3"), ("3", 'png', "content-outside-printable-area", 'precompiled/overlay.png?page_number=3'),
('pdf', 'precompiled/overlay.pdf', "content-outside-printable-area", "") ("", 'pdf', "content-outside-printable-area", 'precompiled/overlay.pdf')
] ]
) )
def test_preview_letter_template_precompiled_png_file_type_or_pdf_with_overlay( def test_preview_letter_template_precompiled_png_file_type_or_pdf_with_overlay(
@@ -1158,10 +1158,10 @@ def test_preview_letter_template_precompiled_png_file_type_or_pdf_with_overlay(
admin_request, admin_request,
sample_service, sample_service,
mocker, mocker,
filetype,
post_url,
message,
requested_page, requested_page,
filetype,
message,
expected_post_url,
): ):
template = create_template(sample_service, template = create_template(sample_service,
@@ -1195,7 +1195,7 @@ def test_preview_letter_template_precompiled_png_file_type_or_pdf_with_overlay(
mocker.patch('app.template.rest.extract_page_from_pdf', return_value=pdf_content) mocker.patch('app.template.rest.extract_page_from_pdf', return_value=pdf_content)
mock_post = request_mock.post( mock_post = request_mock.post(
'http://localhost/notifications-template-preview/{}'.format(post_url), 'http://localhost/notifications-template-preview/{}'.format(expected_post_url),
content=expected_returned_content, content=expected_returned_content,
headers={'X-pdf-page-count': '4'}, headers={'X-pdf-page-count': '4'},
status_code=200 status_code=200