darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-23 15:56:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

There was a misunderstanding about how we wanted the feature to work.

Browse Source 
There is no need for the extra column.
If a template does not have a default address set - they address will be blank.
Otherwise use the address of the service_letter_contact.

There will be another PR to do a db migration.
Template.service_letter_contact = blank if no service_letter_contacts for service ELSE use set Template.serivce_letter_contact_id = service default service_letter_contact
This commit is contained in:
Rebecca Law
2018-01-05 15:32:43 +00:00
parent 89116d683b
commit 9e9b8ab1a3
3 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/app/template/test_rest.py
View File

@@ -625,7 +625,6 @@ def test_get_template_reply_to(client, sample_letter_template):
assert 'service_letter_contact_id' not in json_resp['data']
assert json_resp['data']['reply_to'] == str(letter_contact.id)
assert json_resp['data']['reply_to_text'] == letter_contact.contact_block
assert not json_resp['data']['is_letter_contact_blank']
def test_update_template_reply_to(client, sample_letter_template):