code review feedback

This commit is contained in:
Kenneth Kehl
2024-12-20 07:33:28 -08:00
parent 4bd97586b4
commit 9dc7cfeb2f
2 changed files with 1 additions and 3 deletions

View File

@@ -252,7 +252,7 @@ def process_delivery_receipts(self):
it does fail, we need to go back over at some point when things are running again and process those results. it does fail, we need to go back over at some point when things are running again and process those results.
""" """
try: try:
batch_size = 200 # in theory with postgresql this could be 10k to 20k? batch_size = 1000 # in theory with postgresql this could be 10k to 20k?
cloudwatch = AwsCloudwatchClient() cloudwatch = AwsCloudwatchClient()
cloudwatch.init_app(current_app) cloudwatch.init_app(current_app)

View File

@@ -7,7 +7,6 @@ from flask import current_app
from app.clients import AWS_CLIENT_CONFIG, Client from app.clients import AWS_CLIENT_CONFIG, Client
from app.cloudfoundry_config import cloud_config from app.cloudfoundry_config import cloud_config
from app.utils import hilite
class AwsCloudwatchClient(Client): class AwsCloudwatchClient(Client):
@@ -49,7 +48,6 @@ class AwsCloudwatchClient(Client):
def _get_log(self, log_group_name, start, end): def _get_log(self, log_group_name, start, end):
# Check all cloudwatch logs from the time the notification was sent (currently 5 minutes previously) until now # Check all cloudwatch logs from the time the notification was sent (currently 5 minutes previously) until now
print(hilite(f"START {start} END {end}"))
next_token = None next_token = None
all_log_events = [] all_log_events = []