darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 09:51:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

remove unnecessary unique index

Browse Source 
primary key provides the same control. also catch the right exception
in the related command
This commit is contained in:
Leo Hemsted
2019-05-16 14:36:17 +01:00
parent 907e13da87
commit 9d415cd292
3 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@@ -243,7 +243,7 @@ cf-deploy: scripts/statsd_exporter ## Deploys the app to Cloud Foundry
cf-deploy-api-db-migration: cf-deploy-api-db-migration:
$(if ${CF_SPACE},,$(error Must specify CF_SPACE)) $(if ${CF_SPACE},,$(error Must specify CF_SPACE))
cf target -o ${CF_ORG} -s ${CF_SPACE} cf target -o ${CF_ORG} -s ${CF_SPACE}
cf push notify-api-db-migration -f <(make -s CF_APP=notify-api-db-migration generate-manifest) cf push notify-api-db-migration --no-start --no-route -f <(make -s CF_APP=notify-api-db-migration generate-manifest)
cf run-task notify-api-db-migration "flask db upgrade" --name api_db_migration cf run-task notify-api-db-migration "flask db upgrade" --name api_db_migration
.PHONY: cf-check-api-db-migration-task .PHONY: cf-check-api-db-migration-task

2
app/commands.py
View File

@@ -10,7 +10,7 @@ import itertools
from click_datetime import Datetime as click_dt from click_datetime import Datetime as click_dt
from flask import current_app, json from flask import current_app, json
from notifications_utils.template import SMSMessageTemplate from notifications_utils.template import SMSMessageTemplate
from psycopg2._psycopg import IntegrityError from sqlalchemy.exc import IntegrityError
from sqlalchemy.orm.exc import NoResultFound from sqlalchemy.orm.exc import NoResultFound
from notifications_utils.statsd_decorators import statsd from notifications_utils.statsd_decorators import statsd

21
migrations/versions/0291_remove_unused_index.py Normal file
View File

@@ -0,0 +1,21 @@
"""
Revision ID: 0291_remove_unused_index
Revises: 0290_org_go_live_notes
Create Date: 2019-05-16 14:05:18.104274
"""
from alembic import op
import sqlalchemy as sa
revision = '0291_remove_unused_index'
down_revision = '0290_org_go_live_notes'
def upgrade():
op.drop_index('ix_domain_domain', table_name='domain')
def downgrade():
op.create_index('ix_domain_domain', 'domain', ['domain'], unique=True)