From 542f3b23aa611c0e5bfff1dd32961ffb66db7f5d Mon Sep 17 00:00:00 2001 From: David McDonald Date: Tue, 24 Dec 2019 08:37:19 +0000 Subject: [PATCH] Remove coveralls We don't use it anymore --- .coveralls.yml | 1 - Makefile | 23 ----------------------- README.md | 3 --- requirements_for_test.txt | 1 - 4 files changed, 28 deletions(-) delete mode 100644 .coveralls.yml diff --git a/.coveralls.yml b/.coveralls.yml deleted file mode 100644 index af20d0e52..000000000 --- a/.coveralls.yml +++ /dev/null @@ -1 +0,0 @@ -service_name: jenkins diff --git a/Makefile b/Makefile index 43f635744..280043c11 100644 --- a/Makefile +++ b/Makefile @@ -89,9 +89,6 @@ test-requirements: echo "Run 'make freeze-requirements' to update."; exit 1; } \ || { echo "requirements.txt is up to date"; exit 0; } -.PHONY: coverage -coverage: ; ## don't do anything - .PHONY: prepare-docker-build-image prepare-docker-build-image: generate-version-file ## Prepare the Docker builder image docker build -f docker/Dockerfile \ @@ -131,26 +128,6 @@ create-docker-test-db: ## Start the test database in a Docker container postgres:9.5 sleep 3 -# FIXME: CIRCLECI=1 is an ugly hack because the coveralls-python library sends the PR link only this way -.PHONY: coverage-with-docker -coverage-with-docker: prepare-docker-build-image ## Generates coverage report inside a Docker container - @docker run -i${DOCKER_TTY} --rm \ - --name "${DOCKER_CONTAINER_PREFIX}-coverage" \ - -e COVERALLS_REPO_TOKEN=${COVERALLS_REPO_TOKEN} \ - -e CIRCLECI=1 \ - -e CI_NAME=${CI_NAME} \ - -e CI_BUILD_NUMBER=${BUILD_NUMBER} \ - -e CI_BUILD_URL=${BUILD_URL} \ - -e CI_BRANCH=${GIT_BRANCH} \ - -e CI_PULL_REQUEST=${CI_PULL_REQUEST} \ - -e http_proxy="${HTTP_PROXY}" \ - -e HTTP_PROXY="${HTTP_PROXY}" \ - -e https_proxy="${HTTPS_PROXY}" \ - -e HTTPS_PROXY="${HTTPS_PROXY}" \ - -e NO_PROXY="${NO_PROXY}" \ - ${DOCKER_BUILDER_IMAGE_NAME} \ - make coverage - .PHONY: clean-docker-containers clean-docker-containers: ## Clean up any remaining docker containers docker rm -f $(shell docker ps -q -f "name=${DOCKER_CONTAINER_PREFIX}") 2> /dev/null || true diff --git a/README.md b/README.md index 85c4e45b4..dffed8d00 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,3 @@ -[![Requirements Status](https://requires.io/github/alphagov/notifications-api/requirements.svg?branch=master)](https://requires.io/github/alphagov/notifications-api/requirements/?branch=master) -[![Coverage Status](https://coveralls.io/repos/alphagov/notifications-api/badge.svg?branch=master&service=github)](https://coveralls.io/github/alphagov/notifications-api?branch=master) - # GOV.UK Notify API Contains: diff --git a/requirements_for_test.txt b/requirements_for_test.txt index c8c9cb7f5..7e9bc35a1 100644 --- a/requirements_for_test.txt +++ b/requirements_for_test.txt @@ -5,7 +5,6 @@ pytest==5.2.4 pytest-env==0.6.2 pytest-mock==1.11.2 pytest-cov==2.8.1 -coveralls==1.8.2 pytest-xdist==1.30.0 freezegun==0.3.12 requests-mock==1.7.0