darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-28 21:41:45 -05:00
Code Issues Packages Projects Releases Wiki Activity

Validate against messages with no content

Browse Source
This commit is contained in:
Pea Tyczynska
2019-11-08 13:44:27 +00:00
parent 28ae7705c2
commit 9c804f701b
2 changed files with 34 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/notifications/validators.py
View File

@@ -121,6 +121,12 @@ def check_sms_content_char_count(content_count):
raise BadRequestError(message=message)
def check_if_notification_content_is_not_empty(template_with_content):
if len(template_with_content.__str__()) == 0:
message = 'This message is empty.'
raise BadRequestError(message=message)
def validate_template(template_id, personalisation, service, notification_type):
try:
template = templates_dao.dao_get_template_by_id_and_service_id(
@@ -137,6 +143,7 @@ def validate_template(template_id, personalisation, service, notification_type):
template_with_content = create_content_for_notification(template, personalisation)
if template.template_type == SMS_TYPE:
check_sms_content_char_count(template_with_content.content_count)
check_if_notification_content_is_not_empty(template_with_content)
return template, template_with_content