Allow filtering of notification stats by days

https://www.pivotaltracker.com/story/show/117920839

On the dashboard we want to show counts of notifications sent in the
last 7 days, plus today. So the API enpoint needs to accept an argument
to limit how many days worth of statistics it will return.

This is a bit fiddly at the DAO level because the date is just stored as
a string.
This commit is contained in:
Chris Hill-Scott
2016-04-19 16:34:17 +01:00
parent 16553af133
commit 9c2c9435e3
3 changed files with 72 additions and 4 deletions

View File

@@ -4,7 +4,8 @@ from flask import (
)
from app.dao.notifications_dao import (
dao_get_notification_statistics_for_service
dao_get_notification_statistics_for_service,
dao_get_notification_statistics_for_service_and_previous_days
)
from app.schemas import notifications_statistics_schema
@@ -19,7 +20,20 @@ register_errors(notifications_statistics)
@notifications_statistics.route('', methods=['GET'])
def get_all_templates_for_service(service_id):
templates = dao_get_notification_statistics_for_service(service_id=service_id)
data, errors = notifications_statistics_schema.dump(templates, many=True)
def get_all_notification_statistics_for_service(service_id):
if request.args.get('limit_days'):
try:
statistics = dao_get_notification_statistics_for_service_and_previous_days(
service_id=service_id,
limit_days=int(request.args['limit_days'])
)
except ValueError as e:
error = '{} is not an integer'.format(request.args['limit_days'])
current_app.logger.error(error)
return jsonify(result="error", message={'limit_days': [error]}), 400
else:
statistics = dao_get_notification_statistics_for_service(service_id=service_id)
data, errors = notifications_statistics_schema.dump(statistics, many=True)
return jsonify(data=data)