darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

handle document download errors properly

Browse Source 
if doc download returns a 403, that's a screw-up on our side. it's not
helpful to a notify user for that to be passed on. the only thing they
should care about is if it's a 400, because they uploaded a filetype we
don't allow.

Everything else should return 500 internal server error.
This commit is contained in:
Leo Hemsted
2020-01-10 17:13:10 +00:00
parent 879ba1d5f0
commit 99d008b383
2 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/app/clients/test_document_download.py
View File

@@ -1,4 +1,3 @@
import requests
import requests_mock
import pytest
@@ -33,26 +32,27 @@ def test_upload_document(document_download):
assert resp == 'https://document-download/services/service-id/documents/uploaded-url'
def test_should_raise_for_status(document_download):
def test_should_raise_400s_as_DocumentDownloadErrors(document_download):
with pytest.raises(DocumentDownloadError) as excinfo, requests_mock.Mocker() as request_mock:
request_mock.post('https://document-download/services/service-id/documents', json={
'error': 'Invalid encoding'
}, status_code=403)
'error': 'Invalid mime type'
}, status_code=400)
document_download.upload_document('service-id', 'abababab')
assert excinfo.value.message == 'Invalid encoding'
assert excinfo.value.status_code == 403
assert excinfo.value.message == 'Invalid mime type'
assert excinfo.value.status_code == 400
def test_should_raise_for_connection_errors(document_download):
with pytest.raises(DocumentDownloadError) as excinfo, requests_mock.Mocker() as request_mock:
def test_should_raise_non_400_statuses_as_exceptions(document_download):
with pytest.raises(Exception) as excinfo, requests_mock.Mocker() as request_mock:
request_mock.post(
'https://document-download/services/service-id/documents',
exc=requests.exceptions.ConnectTimeout
json={'error': 'Auth Error Of Some Kind'},
status_code=403
)
document_download.upload_document('service-id', 'abababab')
assert excinfo.value.message == 'connection error'
assert excinfo.value.status_code == 503
assert type(excinfo.value) == Exception # make sure it's a base exception, so will be handled as a 500 by v2 api
assert str(excinfo.value) == 'Unhandled document download error: {"error": "Auth Error Of Some Kind"}'