darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 17:31:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

additional type checking in process_ses_receipt_tasks

Browse Source
This commit is contained in:
jimmoffet
2022-10-04 18:16:19 -07:00
parent 1230579f83
commit 97aa118fee
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/celery/process_ses_receipts_tasks.py
View File

@@ -108,7 +108,7 @@ def determine_notification_bounce_type(ses_message):
return notification_type return notification_type
if notification_type != "Bounce": if notification_type != "Bounce":
raise KeyError(f"Unhandled notification type {notification_type}") raise KeyError(f"Unhandled sns notification type {notification_type}")
remove_emails_from_bounce(ses_message) remove_emails_from_bounce(ses_message)
current_app.logger.info("SES bounce dict: {}".format(json.dumps(ses_message).replace("{", "(").replace("}", ")"))) current_app.logger.info("SES bounce dict: {}".format(json.dumps(ses_message).replace("{", "(").replace("}", ")")))
@@ -116,6 +116,13 @@ def determine_notification_bounce_type(ses_message):
return "Permanent" return "Permanent"
return "Temporary" return "Temporary"
def determine_notification_type(ses_message):
notification_type = ses_message["notificationType"]
if notification_type not in ["Bounce","Complaint","Delivery"]:
raise KeyError(f"Unhandled sns notification type {notification_type}")
if notification_type == 'Bounce':
return determine_notification_bounce_type(ses_message)
return notification_type
def _determine_provider_response(ses_message): def _determine_provider_response(ses_message):
if ses_message["notificationType"] != "Bounce": if ses_message["notificationType"] != "Bounce":
@@ -136,7 +143,7 @@ def _determine_provider_response(ses_message):
def get_aws_responses(ses_message): def get_aws_responses(ses_message):
status = determine_notification_bounce_type(ses_message) status = determine_notification_type(ses_message)
base = { base = {
"Permanent": { "Permanent": {