Don’t wipe domains when updating other attributes

The domains for an organisation should only be updated (or wiped) if a
new list is explicitly passed in by the admin app.

app/dao/organisation_dao.py

@@ -53,7 +53,7 @@ def dao_create_organisation(organisation):
 @transactional
 def dao_update_organisation(organisation_id, **kwargs):
 
-    domains = kwargs.pop('domains', [])
+    domains = kwargs.pop('domains', None)
 
     organisation = Organisation.query.filter_by(id=organisation_id).update(
         kwargs

tests/app/organisation/test_rest.py

@@ -201,6 +201,29 @@ def test_post_update_organisation_updates_domains(
     ] == domain_list
 
 
+def test_update_other_organisation_attributes_doesnt_clear_domains(
+    admin_request,
+    notify_db_session,
+):
+    org = create_organisation(name='test_org_2')
+    create_domain('example.gov.uk', org.id)
+
+    admin_request.post(
+        'organisation.update_organisation',
+        _data={
+            'agreement_signed': True,
+        },
+        organisation_id=org.id,
+        _expected_status=204
+    )
+
+    assert [
+        domain.domain for domain in org.domains
+    ] == [
+        'example.gov.uk'
+    ]
+
+
 def test_post_update_organisation_raises_400_on_existing_org_name(
         admin_request, sample_organisation):
     org = create_organisation()