darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-09 14:59:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

code review feedback

Browse Source
This commit is contained in:
Kenneth Kehl
2024-10-28 13:20:51 -07:00
parent c6fee4a0b0
commit 9638e2b4f0
4 changed files with 4 additions and 282 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/dao/service_permissions_dao.py
View File

@@ -6,9 +6,6 @@ from app.models import ServicePermission
def dao_fetch_service_permissions(service_id):
# return ServicePermission.query.filter(
# ServicePermission.service_id == service_id
# ).all()
stmt = select(ServicePermission).filter(ServicePermission.service_id == service_id)
return db.session.execute(stmt).scalars().all()
@@ -21,12 +18,6 @@ def dao_add_service_permission(service_id, permission):
def dao_remove_service_permission(service_id, permission):
# deleted = ServicePermission.query.filter(
# ServicePermission.service_id == service_id,
# ServicePermission.permission == permission,
# ).delete()
# db.session.commit()
# return deleted
stmt = delete(ServicePermission).where(
ServicePermission.service_id == service_id,