darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 10:21:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Change apostrophes to prettier ones

Browse Source 
Co-Authored-By: Chris Hill-Scott <me@quis.cc>
This commit is contained in:
Pea (Malgorzata Tyczynska)
2019-07-22 10:48:34 +01:00
committed by GitHub
parent e9de84beb0
commit 957cf46748
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/dao/jobs_dao.py
View File

@@ -184,6 +184,6 @@ def can_letter_job_be_cancelled(job):
if count_cancellable_notifications != job.notification_count or not letter_can_be_cancelled( if count_cancellable_notifications != job.notification_count or not letter_can_be_cancelled(
NOTIFICATION_CREATED, job.created_at NOTIFICATION_CREATED, job.created_at
): ):
return False, "It's too late to cancel sending, these letters have already been sent." return False, "It’s too late to cancel sending, these letters have already been sent."
return True, None return True, None

4
tests/app/dao/test_jobs_dao.py
View File

@@ -342,7 +342,7 @@ def test_can_letter_job_be_cancelled_returns_false_and_error_message_if_notifica
create_notification(template=job.template, job=job, status='created') create_notification(template=job.template, job=job, status='created')
result, errors = can_letter_job_be_cancelled(job) result, errors = can_letter_job_be_cancelled(job)
assert not result assert not result
assert errors == "It's too late to cancel sending, these letters have already been sent." assert errors == "It’s too late to cancel sending, these letters have already been sent."
def test_can_letter_job_be_cancelled_returns_false_and_error_message_if_letters_already_sent_to_dvla( def test_can_letter_job_be_cancelled_returns_false_and_error_message_if_letters_already_sent_to_dvla(
@@ -355,7 +355,7 @@ def test_can_letter_job_be_cancelled_returns_false_and_error_message_if_letters_
with freeze_time('2019-06-13 17:32'): with freeze_time('2019-06-13 17:32'):
result, errors = can_letter_job_be_cancelled(job) result, errors = can_letter_job_be_cancelled(job)
assert not result assert not result
assert errors == "It's too late to cancel sending, these letters have already been sent." assert errors == "It’s too late to cancel sending, these letters have already been sent."
assert letter.status == 'created' assert letter.status == 'created'
assert job.job_status == 'finished' assert job.job_status == 'finished'