From 08dcc920a2f4b14047df21ef5bafea884e2bbc52 Mon Sep 17 00:00:00 2001 From: Rebecca Law Date: Mon, 2 Jul 2018 13:48:40 +0100 Subject: [PATCH] Updated notifications-util to the latest version. There has been an update to the email validation code. Added an extra test for email validation. --- requirements.txt | 2 +- tests/app/v2/notifications/test_notification_schemas.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/requirements.txt b/requirements.txt index 44a3dd3c6..d28f55d20 100644 --- a/requirements.txt +++ b/requirements.txt @@ -22,6 +22,6 @@ notifications-python-client==4.8.2 # PaaS awscli-cwlogs>=1.4,<1.5 -git+https://github.com/alphagov/notifications-utils.git@27.0.0#egg=notifications-utils==27.0.0 +git+https://github.com/alphagov/notifications-utils.git@29.3.0#egg=notifications-utils==29.3.0 git+https://github.com/alphagov/boto.git@2.43.0-patch3#egg=boto==2.43.0-patch3 diff --git a/tests/app/v2/notifications/test_notification_schemas.py b/tests/app/v2/notifications/test_notification_schemas.py index 201f35542..55b21cd83 100644 --- a/tests/app/v2/notifications/test_notification_schemas.py +++ b/tests/app/v2/notifications/test_notification_schemas.py @@ -228,6 +228,7 @@ def test_post_email_schema_bad_uuid_and_missing_email_address(): @pytest.mark.parametrize('email_address, err_msg', [ ('example', 'email_address Not a valid email address'), (12345, 'email_address 12345 is not of type string'), + ('with(brackets)@example.com', 'email_address Not a valid email address'), (None, 'email_address None is not of type string'), ([], 'email_address [] is not of type string'), ({}, 'email_address {} is not of type string'),