darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-25 01:41:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1747 from alphagov/add_precompiled_letters

Browse Source 
Fixed bug only where only data being passed to TemplatePreview when JSON is required
This commit is contained in:
Richard Chapman
2018-03-08 09:56:03 +00:00
committed by GitHub
parent ae0113a5de d60e802f35
commit 94dea42f6f
2 changed files with 45 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/app/template/test_rest.py
View File

@@ -828,7 +828,7 @@ def test_preview_letter_template_by_id_valid_file_type(
with requests_mock.Mocker() as request_mock:
content = b'\x00\x01'
request_mock.post(
mock_post = request_mock.post(
'http://localhost/notifications-template-preview/preview.pdf',
content=content,
headers={'X-pdf-page-count': '1'},
@@ -842,6 +842,7 @@ def test_preview_letter_template_by_id_valid_file_type(
file_type='pdf'
)
assert mock_post.last_request.json()
assert base64.b64decode(resp['content']) == content
@@ -859,7 +860,7 @@ def test_preview_letter_template_by_id_template_preview_500(
with requests_mock.Mocker() as request_mock:
content = b'\x00\x01'
request_mock.post(
mock_post = request_mock.post(
'http://localhost/notifications-template-preview/preview.pdf',
content=content,
headers={'X-pdf-page-count': '1'},
@@ -874,7 +875,9 @@ def test_preview_letter_template_by_id_template_preview_500(
_expected_status=500
)
assert resp['message'] == 'Error generating preview for {}'.format(sample_letter_notification.id)
assert mock_post.last_request.json()
assert 'Status code: 404' in resp['message']
assert 'Error generating preview letter for {}'.format(sample_letter_notification.id) in resp['message']
def test_preview_letter_template_precompiled_pdf_file_type(
@@ -978,7 +981,7 @@ def test_preview_letter_template_precompiled_png_file_type(
mock_get_letter_pdf = mocker.patch('app.template.rest.get_letter_pdf', return_value=pdf_content)
request_mock.post(
mock_post = request_mock.post(
'http://localhost/notifications-template-preview/precompiled-preview.png',
content=png_content,
headers={'X-pdf-page-count': '1'},
@@ -992,6 +995,8 @@ def test_preview_letter_template_precompiled_png_file_type(
file_type='png'
)
with pytest.raises(ValueError):
mock_post.last_request.json()
assert mock_get_letter_pdf.called_once_with(notification)
assert base64.b64decode(resp['content']) == png_content
@@ -1023,7 +1028,7 @@ def test_preview_letter_template_precompiled_png_template_preview_500_error(
mocker.patch('app.template.rest.get_letter_pdf', return_value=pdf_content)
request_mock.post(
mock_post = request_mock.post(
'http://localhost/notifications-template-preview/precompiled-preview.png',
content=png_content,
headers={'X-pdf-page-count': '1'},
@@ -1039,6 +1044,9 @@ def test_preview_letter_template_precompiled_png_template_preview_500_error(
)
with pytest.raises(ValueError):
mock_post.last_request.json()
def test_preview_letter_template_precompiled_png_template_preview_400_error(
notify_api,
@@ -1067,7 +1075,7 @@ def test_preview_letter_template_precompiled_png_template_preview_400_error(
mocker.patch('app.template.rest.get_letter_pdf', return_value=pdf_content)
request_mock.post(
mock_post = request_mock.post(
'http://localhost/notifications-template-preview/precompiled-preview.png',
content=png_content,
headers={'X-pdf-page-count': '1'},
@@ -1080,5 +1088,7 @@ def test_preview_letter_template_precompiled_png_template_preview_400_error(
notification_id=notification.id,
file_type='png',
_expected_status=500
)
with pytest.raises(ValueError):
mock_post.last_request.json()