darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 01:41:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Avoid assigning notification.template when creating test objects

Browse Source 
`Notification.template` changed from being a Template relationship
to TemplateHistory. When a relationship attribute is being assigned,
SQLAlchemy checks that the assigned value type matches the relationship
type. Since most tests at the moment create a notification using a
Template instance this check fails.

Rewriting the tests to use TemplateHistory objects would require
changes to the majority of tests. Instead, when creating a notification
objects we assign the foreign key attributes directly. This skips the
SQLAlchemy type check, but we still get the constraint check on the
foreign keys, so a matching TemplateHistory object needs to exist in
the database.
This commit is contained in:
Alexey Bezhan
2017-11-09 14:31:31 +00:00
parent e73513f519
commit 94dae42902
5 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/app/notifications/test_process_letter_notifications.py
View File

@@ -18,7 +18,8 @@ def test_create_letter_notification_creates_notification(sample_letter_template,
assert notification == Notification.query.one()
assert notification.job is None
assert notification.status == NOTIFICATION_CREATED
assert notification.template == sample_letter_template
assert notification.template_id == sample_letter_template.id
assert notification.template_version == sample_letter_template.version
assert notification.api_key == sample_api_key
assert notification.notification_type == LETTER_TYPE
assert notification.key_type == sample_api_key.key_type