mirror of
https://github.com/GSA/notifications-api.git
synced 2026-08-20 14:29:25 -04:00
Avoid assigning notification.template when creating test objects
`Notification.template` changed from being a Template relationship to TemplateHistory. When a relationship attribute is being assigned, SQLAlchemy checks that the assigned value type matches the relationship type. Since most tests at the moment create a notification using a Template instance this check fails. Rewriting the tests to use TemplateHistory objects would require changes to the majority of tests. Instead, when creating a notification objects we assign the foreign key attributes directly. This skips the SQLAlchemy type check, but we still get the constraint check on the foreign keys, so a matching TemplateHistory object needs to exist in the database.
This commit is contained in:
@@ -160,8 +160,7 @@ def create_notification(
|
||||
'job': job,
|
||||
'service_id': template.service.id,
|
||||
'service': template.service,
|
||||
'template_id': template and template.id,
|
||||
'template': template,
|
||||
'template_id': template.id,
|
||||
'template_version': template.version,
|
||||
'status': status,
|
||||
'reference': reference,
|
||||
|
||||
Reference in New Issue
Block a user