darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-17 02:32:32 -05:00
Code Issues Packages Projects Releases Wiki Activity

Updated the schema to return reply_to - which is the id and reply_to_text which is the contact_block

Browse Source
This commit is contained in:
Rebecca Law
2018-02-14 11:20:09 +00:00
parent c833a76070
commit 94162bc1bf
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/schemas.py
View File

@@ -346,7 +346,8 @@ class TemplateSchema(BaseTemplateSchema):
class TemplateHistorySchema(BaseSchema): class TemplateHistorySchema(BaseSchema):
reply_to_text = fields.Method("get_reply_to", allow_none=True) reply_to = fields.Method("get_reply_to", allow_none=True)
reply_to_text = fields.Method("get_reply_to_text", allow_none=True)
created_by = fields.Nested(UserSchema, only=['id', 'name', 'email_address'], dump_only=True) created_by = fields.Nested(UserSchema, only=['id', 'name', 'email_address'], dump_only=True)
created_at = field_for(models.Template, 'created_at', format='%Y-%m-%d %H:%M:%S.%f') created_at = field_for(models.Template, 'created_at', format='%Y-%m-%d %H:%M:%S.%f')
@@ -354,6 +355,9 @@ class TemplateHistorySchema(BaseSchema):
def get_reply_to(self, template): def get_reply_to(self, template):
return template.reply_to return template.reply_to
def get_reply_to_text(self, template):
return template.get_reply_to_text()
class Meta: class Meta:
model = models.TemplateHistory model = models.TemplateHistory

3
tests/app/template/test_rest_history.py
View File

@@ -111,4 +111,5 @@ def test_update_template_reply_to_updates_history(client, sample_letter_template
hist_json_resp = json.loads(resp.get_data(as_text=True)) hist_json_resp = json.loads(resp.get_data(as_text=True))
assert 'service_letter_contact_id' not in hist_json_resp['data'] assert 'service_letter_contact_id' not in hist_json_resp['data']
assert hist_json_resp['data']['reply_to_text'] == str(letter_contact.id) assert hist_json_resp['data']['reply_to'] == str(letter_contact.id)
assert hist_json_resp['data']['reply_to_text'] == letter_contact.contact_block