darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-19 05:58:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

remove last obvious letter tasks and queues

Browse Source
This commit is contained in:
stvnrlly
2022-12-07 21:52:00 -05:00
parent d6f35cf6da
commit 90f3dde344
6 changed files with 2 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/app/dao/notification_dao/test_notification_dao_delete_notifications.py
View File

@@ -156,29 +156,6 @@ def test_move_notifications_deletes_letters_sent_and_in_final_state_from_table_a
s3.get_object(Bucket=bucket_name, Key=filename)
@pytest.mark.parametrize('notification_status', ['pending-virus-check', 'created', 'sending'])
@pytest.mark.skip(reason="Skipping letter-related functionality for now")
def test_move_notifications_does_not_delete_letters_not_yet_in_final_state(
sample_service, mocker, notification_status
):
mock_s3_object = mocker.patch("app.dao.notifications_dao.find_letter_pdf_in_s3").return_value
letter_template = create_template(service=sample_service, template_type='letter')
create_notification(
template=letter_template,
status=notification_status,
reference='LETTER_REF',
created_at=datetime.utcnow() - timedelta(days=8),
)
assert Notification.query.count() == 1
assert NotificationHistory.query.count() == 0
move_notifications_to_notification_history('letter', sample_service.id, datetime.utcnow())
assert Notification.query.count() == 1
assert NotificationHistory.query.count() == 0
mock_s3_object.assert_not_called()
def test_move_notifications_only_moves_notifications_older_than_provided_timestamp(sample_template):
delete_time = datetime(2020, 6, 1, 12)
one_second_before = delete_time - timedelta(seconds=1)