darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-30 14:31:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

Return cancelled letters for dashboard

Browse Source 
Added cancelled letters to the number of failed letters in the statistics
that get used for the dashboard. At some point, we want to stop
including cancelled letters in the stats, but for now this keeps things
consistent with our current letter failure state, permanent-failure.
This commit is contained in:
Katie Smith
2018-11-22 15:17:17 +00:00
parent 1d67b55b16
commit 90d9135fcf
3 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/app/service/test_statistics.py
View File

@@ -38,7 +38,8 @@ NewStatsRow = collections.namedtuple('row', ('notification_type', 'status', 'key
StatsRow('letter', 'validation-failed', 1),
StatsRow('letter', 'virus-scan-failed', 1),
StatsRow('letter', 'permanent-failure', 1),
], [4, 0, 4], [0, 0, 0], [3, 0, 3]),
StatsRow('letter', 'cancelled', 1),
], [4, 0, 4], [0, 0, 0], [4, 0, 4]),
'convert_sent_to_delivered': ([
StatsRow('sms', 'sending', 1),
StatsRow('sms', 'delivered', 1),