mirror of
https://github.com/GSA/notifications-api.git
synced 2026-01-31 23:26:23 -05:00
Update update_notification_status_by_id DAO function
Replaced `.with_for_lockmode()`, which is now deprecated, with `.with_for_update() - https://docs.sqlalchemy.org/en/latest/orm/query.html#sqlalchemy.orm.query.Query.with_lockmode The function should update any statuses that are not 'final', so added `pending-virus-check` to the list of statuses that the function can update.
This commit is contained in:
@@ -141,6 +141,14 @@ def test_should_update_status_by_id_if_created(notify_db, notify_db_session):
|
||||
assert updated.status == 'failed'
|
||||
|
||||
|
||||
def test_should_update_status_by_id_if_pending_virus_check(notify_db, notify_db_session):
|
||||
notification = sample_notification(notify_db, notify_db_session, status='pending-virus-check')
|
||||
assert Notification.query.get(notification.id).status == 'pending-virus-check'
|
||||
updated = update_notification_status_by_id(notification.id, 'cancelled')
|
||||
assert Notification.query.get(notification.id).status == 'cancelled'
|
||||
assert updated.status == 'cancelled'
|
||||
|
||||
|
||||
def test_should_update_status_by_id_and_set_sent_by(notify_db, notify_db_session):
|
||||
notification = sample_notification(notify_db, notify_db_session, status='sending')
|
||||
|
||||
|
||||
Reference in New Issue
Block a user