darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 10:21:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove the abstract ClientResponses class. Refactor aws_ses not to require the class.

Browse Source 
All three client now use a response_map for the delivery receipt processing.
This commit is contained in:
Rebecca Law
2016-04-06 16:34:45 +01:00
parent 323b2ff537
commit 90194cbbb8
4 changed files with 61 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
tests/app/clients/test_aws_ses.py
View File

@@ -1,32 +1,33 @@
import pytest
from app.clients.email import aws_ses
aws_responses = aws_ses.AwsSesResponses()
from app.clients.email.aws_ses import get_aws_responses
def test_should_return_correct_details_for_delivery():
assert aws_responses.response_code_to_message('Delivery') == 'Delivered'
assert aws_responses.response_code_to_notification_status('Delivery') == 'delivered'
assert aws_responses.response_code_to_notification_statistics_status('Delivery') == 'delivered'
assert aws_responses.response_code_to_notification_success('Delivery')
response_dict = get_aws_responses('Delivery')
assert response_dict['message'] == 'Delivered'
assert response_dict['notification_status'] == 'delivered'
assert response_dict['notification_statistics_status'] == 'delivered'
assert response_dict['success']
def test_should_return_correct_details_for_bounced():
assert aws_responses.response_code_to_message('Bounce') == 'Bounced'
assert aws_responses.response_code_to_notification_status('Bounce') == 'bounce'
assert aws_responses.response_code_to_notification_statistics_status('Bounce') == 'failure'
assert not aws_responses.response_code_to_notification_success('Bounce')
response_dict = get_aws_responses('Bounce')
assert response_dict['message'] == 'Bounced'
assert response_dict['notification_status'] == 'bounce'
assert response_dict['notification_statistics_status'] == 'failure'
assert not response_dict['success']
def test_should_return_correct_details_for_complaint():
assert aws_responses.response_code_to_message('Complaint') == 'Complaint'
assert aws_responses.response_code_to_notification_status('Complaint') == 'complaint'
assert aws_responses.response_code_to_notification_statistics_status('Complaint') == 'failure'
assert not aws_responses.response_code_to_notification_success('Complaint')
response_dict = get_aws_responses('Complaint')
assert response_dict['message'] == 'Complaint'
assert response_dict['notification_status'] == 'complaint'
assert response_dict['notification_statistics_status'] == 'failure'
assert not response_dict['success']
def test_should_be_none_if_unrecognised_status_code():
with pytest.raises(KeyError) as e:
aws_responses.response_code_to_object('99')
get_aws_responses('99')
assert '99' in str(e.value)