darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-30 06:21:50 -05:00
Code Issues Packages Projects Releases Wiki Activity

remove deprecated notification

Browse Source
This commit is contained in:
Kenneth Kehl
2024-04-11 10:28:09 -07:00
parent e877fc6885
commit 8fba67170e
4 changed files with 11 additions and 140 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
tests/app/celery/test_scheduled_tasks.py
View File

@@ -8,7 +8,6 @@ from notifications_utils.clients.zendesk.zendesk_client import NotifySupportTick
from app.celery import scheduled_tasks
from app.celery.scheduled_tasks import (
check_db_notification_fails,
check_for_missing_rows_in_completed_jobs,
check_for_services_with_high_failure_rates_or_sending_to_tv_numbers,
check_job_status,
@@ -49,53 +48,6 @@ def test_should_call_expire_or_delete_invotations_on_expire_or_delete_invitation
)
def test_should_check_db_notification_fails_task_over_100_percent(
notify_db_session, mocker
):
mock_dao = mocker.patch(
"app.celery.scheduled_tasks.dao_get_failed_notification_count"
)
mock_provider = mocker.patch("app.celery.scheduled_tasks.provider_to_use")
mock_dao.return_value = 100000
check_db_notification_fails()
assert mock_provider.call_count == 1
def test_should_check_db_notification_fails_task_less_than_25_percent(
notify_db_session, mocker
):
mock_dao = mocker.patch(
"app.celery.scheduled_tasks.dao_get_failed_notification_count"
)
mock_redis = mocker.patch("app.celery.scheduled_tasks.redis_store")
mock_redis.get.return_value = 0
mock_provider = mocker.patch("app.celery.scheduled_tasks.provider_to_use")
mock_dao.return_value = 10
check_db_notification_fails()
assert mock_provider.call_count == 0
def test_should_check_db_notification_fails_task_over_50_percent(
notify_db_session, mocker
):
# This tests that we only send an alert the 1st time we cross over 50%. We don't want
# to be sending the same alert every hour, especially as it might be quite normal for the db
# fails to be at 25 or 50 for long periods of time.
mock_dao = mocker.patch(
"app.celery.scheduled_tasks.dao_get_failed_notification_count"
)
mock_provider = mocker.patch("app.celery.scheduled_tasks.provider_to_use")
mock_redis = mocker.patch("app.celery.scheduled_tasks.redis_store")
mock_dao.return_value = 5001
mock_redis.get.return_value = "0".encode("utf-8")
check_db_notification_fails()
assert mock_provider.call_count == 1
mock_redis.get.return_value = "5001".encode("utf-8")
check_db_notification_fails()
assert mock_provider.call_count == 1
def test_should_update_scheduled_jobs_and_put_on_queue(mocker, sample_template):
mocked = mocker.patch("app.celery.tasks.process_job.apply_async")

16
tests/app/user/test_rest_verify.py
View File

@@ -200,10 +200,10 @@ def test_send_user_sms_code(client, sample_user, sms_code_template, mocker):
"""
notify_service = dao_fetch_service_by_id(current_app.config["NOTIFY_SERVICE_ID"])
mock_redis_get = mocker.patch("app.celery.scheduled_tasks.redis_store.raw_get")
mock_redis_get = mocker.patch("app.user.rest.redis_store.raw_get")
mock_redis_get.return_value = "foo"
mocker.patch("app.celery.scheduled_tasks.redis_store.raw_set")
mocker.patch("app.user.rest.redis_store.raw_set")
auth_header = create_admin_authorization_header()
mocked = mocker.patch("app.user.rest.create_secret_code", return_value="11111")
mocker.patch("app.celery.provider_tasks.deliver_sms.apply_async")
@@ -241,10 +241,10 @@ def test_send_user_code_for_sms_with_optional_to_field(
Tests POST endpoint /user/<user_id>/sms-code with optional to field
"""
mock_redis_get = mocker.patch("app.celery.scheduled_tasks.redis_store.raw_get")
mock_redis_get = mocker.patch("app.user.rest.redis_store.raw_get")
mock_redis_get.return_value = "foo"
mocker.patch("app.celery.scheduled_tasks.redis_store.raw_set")
mocker.patch("app.user.rest.redis_store.raw_set")
to_number = "+447119876757"
mocked = mocker.patch("app.user.rest.create_secret_code", return_value="11111")
mocker.patch("app.celery.provider_tasks.deliver_sms.apply_async")
@@ -468,10 +468,10 @@ def test_send_user_email_code(
deliver_email = mocker.patch("app.celery.provider_tasks.deliver_email.apply_async")
sample_user.auth_type = auth_type
mock_redis_get = mocker.patch("app.celery.scheduled_tasks.redis_store.raw_get")
mock_redis_get = mocker.patch("app.user.rest.redis_store.raw_get")
mock_redis_get.return_value = "foo"
mocker.patch("app.celery.scheduled_tasks.redis_store.raw_set")
mocker.patch("app.user.rest.redis_store.raw_set")
admin_request.post(
"user.send_user_2fa_code",
@@ -584,10 +584,10 @@ def test_user_verify_email_code_fails_if_code_already_used(
def test_send_user_2fa_code_sends_from_number_for_international_numbers(
client, sample_user, mocker, sms_code_template
):
mock_redis_get = mocker.patch("app.celery.scheduled_tasks.redis_store.raw_get")
mock_redis_get = mocker.patch("app.user.rest.redis_store.raw_get")
mock_redis_get.return_value = "foo"
mocker.patch("app.celery.scheduled_tasks.redis_store.raw_set")
mocker.patch("app.user.rest.redis_store.raw_set")
sample_user.mobile_number = "+601117224412"
auth_header = create_admin_authorization_header()