darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-24 00:06:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

remove unused provider dao functions

Browse Source
This commit is contained in:
Leo Hemsted
2019-11-11 14:47:20 +00:00
parent fa7e0a1e84
commit 8fa7cde593
3 changed files with 19 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
tests/app/dao/test_provider_details_dao.py
View File

@@ -11,11 +11,9 @@ from app.dao.provider_details_dao import (
get_current_provider,
get_provider_details_by_identifier,
get_provider_details_by_notification_type,
dao_switch_sms_provider_to_provider_with_identifier,
dao_update_provider_details,
dao_get_provider_stats,
dao_get_provider_versions,
dao_get_sms_provider_with_equal_priority,
dao_reduce_sms_provider_priority,
)
from tests.app.db import (
@@ -135,32 +133,6 @@ def test_get_alternative_sms_provider_fails_if_unrecognised():
get_alternative_sms_provider('ses')
def test_switch_sms_provider_to_current_provider_does_not_switch(
restore_provider_details,
current_sms_provider
):
dao_switch_sms_provider_to_provider_with_identifier(current_sms_provider.identifier)
new_provider = get_current_provider('sms')
assert current_sms_provider.id == new_provider.id
assert current_sms_provider.identifier == new_provider.identifier
def test_switch_sms_provider_to_inactive_provider_does_not_switch(
restore_provider_details,
current_sms_provider
):
alternative_sms_provider = get_alternative_sms_provider(current_sms_provider.identifier)
alternative_sms_provider.active = False
dao_update_provider_details(alternative_sms_provider)
dao_switch_sms_provider_to_provider_with_identifier(alternative_sms_provider.identifier)
new_provider = get_current_provider('sms')
assert new_provider.id == current_sms_provider.id
assert new_provider.identifier == current_sms_provider.identifier
@pytest.mark.parametrize(['starting_priorities', 'expected_priorities'], [
({'mmg': 50, 'firetext': 50}, {'mmg': 40, 'firetext': 60}),
({'mmg': 0, 'firetext': 20}, {'mmg': 0, 'firetext': 30}), # lower bound respected
@@ -287,21 +259,6 @@ def test_can_get_all_provider_history(restore_provider_details, current_sms_prov
assert len(dao_get_provider_versions(current_sms_provider.id)) == 1
def test_get_sms_provider_with_equal_priority_returns_provider(
restore_provider_details
):
current_provider = get_current_provider('sms')
new_provider = get_alternative_sms_provider(current_provider.identifier)
current_provider.priority = new_provider.priority
dao_update_provider_details(current_provider)
conflicting_provider = \
dao_get_sms_provider_with_equal_priority(current_provider.identifier, current_provider.priority)
assert conflicting_provider
def test_get_current_sms_provider_returns_active_only(restore_provider_details):
current_provider = get_current_provider('sms')
current_provider.active = False