darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 01:41:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

More fixes.

Browse Source 
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
This commit is contained in:
Cliff Hill
2024-02-16 16:30:17 -05:00
parent 287dcd6a46
commit 8e8749a40e
3 changed files with 197 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
tests/app/service/test_service_data_retention_rest.py
View File

@@ -1,6 +1,7 @@
import json
import uuid
from app.enums import NotificationType
from app.models import ServiceDataRetention
from tests import create_admin_authorization_header
from tests.app.db import create_service_data_retention
@@ -13,7 +14,7 @@ def test_get_service_data_retention(client, sample_service):
)
response = client.get(
"/service/{}/data-retention".format(str(sample_service.id)),
f"/service/{sample_service.id!s}/data-retention",
headers=[
("Content-Type", "application/json"),
create_admin_authorization_header(),
@@ -29,7 +30,7 @@ def test_get_service_data_retention(client, sample_service):
def test_get_service_data_retention_returns_empty_list(client, sample_service):
response = client.get(
"/service/{}/data-retention".format(str(sample_service.id)),
f"/service/{sample_service.id!s}/data-retention",
headers=[
("Content-Type", "application/json"),
create_admin_authorization_header(),
@@ -42,9 +43,8 @@ def test_get_service_data_retention_returns_empty_list(client, sample_service):
def test_get_data_retention_for_service_notification_type(client, sample_service):
data_retention = create_service_data_retention(service=sample_service)
response = client.get(
"/service/{}/data-retention/notification-type/{}".format(
sample_service.id, "sms"
),
f"/service/{sample_service.id}/data-retention/"
f"notification-type/{NotificationType.SMS}",
headers=[
("Content-Type", "application/json"),
create_admin_authorization_header(),
@@ -57,15 +57,17 @@ def test_get_data_retention_for_service_notification_type(client, sample_service
def test_get_service_data_retention_by_id(client, sample_service):
sms_data_retention = create_service_data_retention(service=sample_service)
create_service_data_retention(
service=sample_service, notification_type="email", days_of_retention=10
service=sample_service,
notification_type=NotificationType.EMAIL,
days_of_retention=10,
)
create_service_data_retention(
service=sample_service, notification_type="letter", days_of_retention=30
service=sample_service,
notification_type=NotificationType.LETTER,
days_of_retention=30,
)
response = client.get(
"/service/{}/data-retention/{}".format(
str(sample_service.id), sms_data_retention.id
),
f"/service/{sample_service.id!s}/data-retention/{sms_data_retention.id}",
headers=[
("Content-Type", "application/json"),
create_admin_authorization_header(),
@@ -79,7 +81,7 @@ def test_get_service_data_retention_by_id_returns_none_when_no_data_retention_ex
client, sample_service
):
response = client.get(
"/service/{}/data-retention/{}".format(str(sample_service.id), uuid.uuid4()),
f"/service/{sample_service.id!s}/data-retention/{uuid.uuid4()}",
headers=[
("Content-Type", "application/json"),
create_admin_authorization_header(),
@@ -90,9 +92,9 @@ def test_get_service_data_retention_by_id_returns_none_when_no_data_retention_ex
def test_create_service_data_retention(client, sample_service):
data = {"notification_type": "sms", "days_of_retention": 3}
data = {"notification_type": NotificationType.SMS, "days_of_retention": 3}
response = client.post(
"/service/{}/data-retention".format(str(sample_service.id)),
f"/service/{sample_service.id!s}/data-retention",
headers=[
("Content-Type", "application/json"),
create_admin_authorization_header(),
@@ -113,7 +115,7 @@ def test_create_service_data_retention_returns_400_when_notification_type_is_inv
):
data = {"notification_type": "unknown", "days_of_retention": 3}
response = client.post(
"/service/{}/data-retention".format(str(uuid.uuid4())),
f"/service/{uuid.uuid4()!s}/data-retention",
headers=[
("Content-Type", "application/json"),
create_admin_authorization_header(),
@@ -133,9 +135,9 @@ def test_create_service_data_retention_returns_400_when_data_retention_for_notif
client, sample_service
):
create_service_data_retention(service=sample_service)
data = {"notification_type": "sms", "days_of_retention": 3}
data = {"notification_type": NotificationType.SMS, "days_of_retention": 3}
response = client.post(
"/service/{}/data-retention".format(str(uuid.uuid4())),
f"/service/{uuid.uuid4()!s}/data-retention",
headers=[
("Content-Type", "application/json"),
create_admin_authorization_header(),
@@ -156,7 +158,7 @@ def test_modify_service_data_retention(client, sample_service):
data_retention = create_service_data_retention(service=sample_service)
data = {"days_of_retention": 3}
response = client.post(
"/service/{}/data-retention/{}".format(sample_service.id, data_retention.id),
f"/service/{sample_service.id}/data-retention/{data_retention.id}",
headers=[
("Content-Type", "application/json"),
create_admin_authorization_header(),
@@ -172,7 +174,7 @@ def test_modify_service_data_retention_returns_400_when_data_retention_does_not_
):
data = {"days_of_retention": 3}
response = client.post(
"/service/{}/data-retention/{}".format(sample_service.id, uuid.uuid4()),
f"/service/{sample_service.id}/data-retention/{uuid.uuid4()}",
headers=[
("Content-Type", "application/json"),
create_admin_authorization_header(),
@@ -186,7 +188,7 @@ def test_modify_service_data_retention_returns_400_when_data_retention_does_not_
def test_modify_service_data_retention_returns_400_when_data_is_invalid(client):
data = {"bad_key": 3}
response = client.post(
"/service/{}/data-retention/{}".format(uuid.uuid4(), uuid.uuid4()),
f"/service/{uuid.uuid4()}/data-retention/{uuid.uuid4()}",
headers=[
("Content-Type", "application/json"),
create_admin_authorization_header(),