darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 02:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #907 from alphagov/upper-case-dvla-ids

Browse Source 
Upper case only in the random notification id generator
This commit is contained in:
minglis
2017-04-21 14:26:03 +01:00
committed by GitHub
parent 6c703840c2 5550201939
commit 8d4f9813f8
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/__init__.py
View File

@@ -211,7 +211,7 @@ def create_uuid():
def create_random_identifier(): def create_random_identifier():
return ''.join(random.choice(string.ascii_letters + string.digits) for _ in range(16)) return ''.join(random.choice(string.ascii_uppercase + string.digits) for _ in range(16))
def process_user_agent(user_agent_string): def process_user_agent(user_agent_string):

4
tests/app/celery/test_tasks.py
View File

@@ -1044,9 +1044,7 @@ def test_create_dvla_file_contents(sample_letter_template, mocker):
def test_dvla_letter_template(sample_letter_notification): def test_dvla_letter_template(sample_letter_notification):
t = {"content": sample_letter_notification.template.content, t = {"content": sample_letter_notification.template.content,
"subject": sample_letter_notification.template.subject} "subject": sample_letter_notification.template.subject}
letter = LetterDVLATemplate(t, letter = LetterDVLATemplate(t, sample_letter_notification.personalisation, "random-string")
sample_letter_notification.personalisation,
"random-string")
assert str(letter) == "140|500|001||random-string|||||||||||||A1||A2|A3|A4|A5|A6|A_POST|||||||||23 March 2017<cr><cr><h1>Template subject<normal><cr><cr>Dear Sir/Madam, Hello. Yours Truly, The Government.<cr><cr>" # noqa assert str(letter) == "140|500|001||random-string|||||||||||||A1||A2|A3|A4|A5|A6|A_POST|||||||||23 March 2017<cr><cr><h1>Template subject<normal><cr><cr>Dear Sir/Madam, Hello. Yours Truly, The Government.<cr><cr>" # noqa