darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-22 16:31:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

Use POST endpoint for updating a user attr

Browse Source
This commit is contained in:
Imdad Ahad
2016-11-10 12:07:29 +00:00
parent 31dfc36094
commit 8b64aa7e79
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/user/rest.py
View File

@@ -69,7 +69,7 @@ def update_user(user_id):
return jsonify(data=user_schema.dump(user_to_update).data), 200 return jsonify(data=user_schema.dump(user_to_update).data), 200
@user.route('/<uuid:user_id>/update-attribute', methods=['PUT']) @user.route('/<uuid:user_id>', methods=['POST'])
def update_user_attribute(user_id): def update_user_attribute(user_id):
user_to_update = get_user_by_id(user_id=user_id) user_to_update = get_user_by_id(user_id=user_id)
req_json = request.get_json() req_json = request.get_json()

4
tests/app/user/test_rest.py
View File

@@ -186,7 +186,7 @@ def test_put_user(notify_api, notify_db, notify_db_session, sample_service):
('email_address', 'newuser@mail.com'), ('email_address', 'newuser@mail.com'),
('mobile_number', '+4407700900460') ('mobile_number', '+4407700900460')
]) ])
def test_put_user_attribute(client, sample_user, user_attribute, user_value): def test_post_user_attribute(client, sample_user, user_attribute, user_value):
assert getattr(sample_user, user_attribute) != user_value assert getattr(sample_user, user_attribute) != user_value
update_dict = { update_dict = {
user_attribute: user_value user_attribute: user_value
@@ -194,7 +194,7 @@ def test_put_user_attribute(client, sample_user, user_attribute, user_value):
auth_header = create_authorization_header() auth_header = create_authorization_header()
headers = [('Content-Type', 'application/json'), auth_header] headers = [('Content-Type', 'application/json'), auth_header]
resp = client.put( resp = client.post(
url_for('user.update_user_attribute', user_id=sample_user.id), url_for('user.update_user_attribute', user_id=sample_user.id),
data=json.dumps(update_dict), data=json.dumps(update_dict),
headers=headers) headers=headers)