darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 09:26:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

move schema import in to function level

Browse Source 
solves `AttributeError: 'DummySession' object has no attribute 'query'`

if you don't do this you get really hard to diagnose errors in unrelated
tests, due to strange import order problems or something
This commit is contained in:
Leo Hemsted
2020-07-09 20:10:34 +01:00
parent 403885722e
commit 8b4a954f2b
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/celery/broadcast_message_tasks.py
View File

@@ -3,8 +3,6 @@ from flask import current_app
from notifications_utils.statsd_decorators import statsd
from app import notify_celery
from app.schemas import template_schema
from app.dao.broadcast_message_dao import dao_get_broadcast_message_by_id
@@ -12,6 +10,10 @@ from app.dao.broadcast_message_dao import dao_get_broadcast_message_by_id
@notify_celery.task(name="send-broadcast-message")
@statsd(namespace="tasks")
def send_broadcast_message(broadcast_message_id, provider='stub-1'):
# imports of schemas from tasks have to happen within functions to prevent
# `AttributeError: 'DummySession' object has no attribute 'query'` errors in unrelated tests
from app.schemas import template_schema
broadcast_message = dao_get_broadcast_message_by_id(broadcast_message_id)
current_app.logger.info(