darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-18 13:38:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

clean up after model update

Browse Source
This commit is contained in:
stvnrlly
2023-02-28 15:29:36 -05:00
parent d6633aea5c
commit 8adf1a19bb
5 changed files with 93 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/app/dao/test_service_data_retention_dao.py
View File

@@ -17,27 +17,23 @@ from tests.app.db import create_service, create_service_data_retention
def test_fetch_service_data_retention(sample_service):
email_data_retention = insert_service_data_retention(sample_service.id, 'email', 3)
letter_data_retention = insert_service_data_retention(sample_service.id, 'letter', 30)
sms_data_retention = insert_service_data_retention(sample_service.id, 'sms', 5)
list_of_data_retention = fetch_service_data_retention(sample_service.id)
assert len(list_of_data_retention) == 3
assert len(list_of_data_retention) == 2
assert list_of_data_retention[0] == email_data_retention
assert list_of_data_retention[1] == sms_data_retention
assert list_of_data_retention[2] == letter_data_retention
def test_fetch_service_data_retention_only_returns_row_for_service(sample_service):
another_service = create_service(service_name="Another service")
email_data_retention = insert_service_data_retention(sample_service.id, 'email', 3)
letter_data_retention = insert_service_data_retention(sample_service.id, 'letter', 30)
insert_service_data_retention(another_service.id, 'sms', 5)
list_of_data_retention = fetch_service_data_retention(sample_service.id)
assert len(list_of_data_retention) == 2
assert len(list_of_data_retention) == 1
assert list_of_data_retention[0] == email_data_retention
assert list_of_data_retention[1] == letter_data_retention
def test_fetch_service_data_retention_returns_empty_list_when_no_rows_for_service(sample_service):
@@ -136,9 +132,7 @@ def test_update_service_data_retention_does_not_update_row_if_data_retention_is_
@pytest.mark.parametrize('notification_type, alternate',
[('sms', 'email'),
('email', 'sms'),
('letter', 'email'),
('letter', 'sms')]
('email', 'sms'),]
)
def test_fetch_service_data_retention_by_notification_type(sample_service, notification_type, alternate):
data_retention = create_service_data_retention(service=sample_service, notification_type=notification_type)

2
tests/app/provider_details/test_rest.py
View File

@@ -11,7 +11,7 @@ def test_get_provider_details_returns_all_providers(admin_request, notify_db_ses
json_resp = admin_request.get('provider_details.get_providers')['provider_details']
assert len(json_resp) > 0
assert {'ses', 'sns', 'dvla'} == {x['identifier'] for x in json_resp}
assert {'ses', 'sns'} == {x['identifier'] for x in json_resp}
def test_get_provider_details_by_id(client, notify_db_session):

4
tests/app/test_model.py
View File

@@ -69,10 +69,6 @@ def test_should_not_build_service_guest_list_from_invalid_contact(recipient_type
([NOTIFICATION_FAILED, NOTIFICATION_CREATED], NOTIFICATION_STATUS_TYPES_FAILED + [NOTIFICATION_CREATED]),
([NOTIFICATION_CREATED, NOTIFICATION_PENDING], [NOTIFICATION_CREATED, NOTIFICATION_PENDING]),
([NOTIFICATION_CREATED, NOTIFICATION_TECHNICAL_FAILURE], [NOTIFICATION_CREATED, NOTIFICATION_TECHNICAL_FAILURE]),
(
[NOTIFICATION_FAILED, NOTIFICATION_SENDING],
NOTIFICATION_STATUS_TYPES_FAILED + [NOTIFICATION_SENDING, NOTIFICATION_CREATED]
),
# checking we don't end up with duplicates
(
[NOTIFICATION_FAILED, NOTIFICATION_CREATED, NOTIFICATION_TECHNICAL_FAILURE],