darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update notifications-utils version.

Browse Source 
Postal address validation now includes `< >` in the invalid characters allowed at the start of an address line.
This commit is contained in:
Rebecca Law
2021-02-08 16:08:12 +00:00
parent c2191d3a0e
commit 87cf3afdc9
4 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/notifications/validators.py
View File

@@ -251,7 +251,7 @@ def validate_address(service, letter_data):
) )
if address.has_invalid_characters: if address.has_invalid_characters:
raise ValidationError( raise ValidationError(
message='Address lines must not start with any of the following characters: @ ( ) = [ ] ” \\ / ,' message='Address lines must not start with any of the following characters: @ ( ) = [ ] ” \\ / , < >'
) )
if address.international: if address.international:
return address.postage return address.postage

2
requirements-app.txt
View File

@@ -33,7 +33,7 @@ notifications-python-client==5.7.1
# PaaS # PaaS
awscli-cwlogs==1.4.6 awscli-cwlogs==1.4.6
git+https://github.com/alphagov/notifications-utils.git@43.8.1#egg=notifications-utils==43.8.1 git+https://github.com/alphagov/notifications-utils.git@43.8.3#egg=notifications-utils==43.8.3
# gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains # gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains
prometheus-client==0.9.0 prometheus-client==0.9.0

17
requirements.txt
View File

@@ -35,7 +35,7 @@ notifications-python-client==5.7.1
# PaaS # PaaS
awscli-cwlogs==1.4.6 awscli-cwlogs==1.4.6
git+https://github.com/alphagov/notifications-utils.git@43.8.1#egg=notifications-utils==43.8.1 git+https://github.com/alphagov/notifications-utils.git@43.8.3#egg=notifications-utils==43.8.3
# gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains # gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains
prometheus-client==0.9.0 prometheus-client==0.9.0
@@ -46,14 +46,14 @@ alembic==1.5.4
amqp==1.4.9 amqp==1.4.9
anyjson==0.3.3 anyjson==0.3.3
attrs==20.3.0 attrs==20.3.0
awscli==1.19.3 awscli==1.19.5
bcrypt==3.2.0 bcrypt==3.2.0
billiard==3.3.0.23 billiard==3.3.0.23
bleach==3.2.1 bleach==3.3.0
blinker==1.4 blinker==1.4
boto==2.49.0 boto==2.49.0
boto3==1.17.3 boto3==1.17.5
botocore==1.20.3 botocore==1.20.5
certifi==2020.12.5 certifi==2020.12.5
chardet==4.0.0 chardet==4.0.0
click==7.1.2 click==7.1.2
@@ -66,6 +66,7 @@ geojson==2.5.0
govuk-bank-holidays==0.8 govuk-bank-holidays==0.8
greenlet==1.0.0 greenlet==1.0.0
idna==2.10 idna==2.10
importlib-metadata==3.4.0
Jinja2==2.11.3 Jinja2==2.11.3
jmespath==0.10.0 jmespath==0.10.0
kombu==3.0.37 kombu==3.0.37
@@ -75,7 +76,7 @@ mistune==0.8.4
monotonic==1.5 monotonic==1.5
orderedset==2.0.3 orderedset==2.0.3
packaging==20.9 packaging==20.9
phonenumbers==8.12.17 phonenumbers==8.12.18
pyasn1==0.4.8 pyasn1==0.4.8
pycparser==2.20 pycparser==2.20
pyparsing==2.4.7 pyparsing==2.4.7
@@ -93,8 +94,10 @@ s3transfer==0.3.4
Shapely==1.7.1 Shapely==1.7.1
six==1.15.0 six==1.15.0
smartypants==2.0.1 smartypants==2.0.1
soupsieve==2.1 soupsieve==2.2
statsd==3.3.0 statsd==3.3.0
typing-extensions==3.7.4.3
urllib3==1.26.3 urllib3==1.26.3
webencodings==0.5.1 webencodings==0.5.1
Werkzeug==1.0.1 Werkzeug==1.0.1
zipp==3.4.0

2
tests/app/v2/notifications/test_post_letter_notifications.py
View File

@@ -221,7 +221,7 @@ def test_post_letter_notification_international_sets_rest_of_world(
'postcode': 'SW1A 1AA', 'postcode': 'SW1A 1AA',
'name': 'Lizzie' 'name': 'Lizzie'
}, },
'Address lines must not start with any of the following characters: @ ( ) = [ ] ” \\ / ,', 'Address lines must not start with any of the following characters: @ ( ) = [ ] ” \\ / , < >',
), ),
( (
[LETTER_TYPE, INTERNATIONAL_LETTERS], [LETTER_TYPE, INTERNATIONAL_LETTERS],